Page MenuHomeDevCentral
Differential D489

Fix getObjectType and getProjectsPHIDs exceptions
ClosedPublic
Actions

Authored by dereckson on Jul 11 2016, 02:48.
Tags
None
Referenced Files
F3619907: D489.diff
Thu, Oct 3, 11:12
Unknown Object (File)
Tue, Oct 1, 06:34
Unknown Object (File)
Tue, Oct 1, 06:34
Unknown Object (File)
Tue, Oct 1, 05:25
Unknown Object (File)
Tue, Oct 1, 05:07
Unknown Object (File)
Sun, Sep 22, 13:29
Unknown Object (File)
Sat, Sep 21, 20:00
Unknown Object (File)
Wed, Sep 18, 19:17
View All Files
Subscribers
None

Details

Reviewers
dereckson
Maniphest Tasks
T917: Test Aphlict notifications trigger a 500 error
Commits
rNOTIF544a5b2b7d01: Fix getObjectType and getProjectsPHIDs exceptions
Summary

Sometimes, a story is sent without any objectPHID field.
For example, test notifications to verify Aphlict settings have
no object attached.

This code handles those cases adding extra check for data presence.

Fixes T917.

Test Plan

Fire a failed notification

Diff Detail

Repository
rNOTIF Notifications center
Lint
Lint Passed
Unit
No Test Coverage
Branch
T917

Event Timeline

dereckson updated this revision to Diff 1187.Jul 11 2016, 02:48
dereckson added a task: T917: Test Aphlict notifications trigger a 500 error.
dereckson retitled this revision from to Fix getObjectType and getProjectsPHIDs exceptions.
dereckson updated this object.
dereckson edited the test plan for this revision. (Show Details)
dereckson added a reviewer: dereckson.
dereckson accepted this revision.Jul 11 2016, 02:51
dereckson edited edge metadata.

[02:45:02] <Nasqueron/nasqueron> This is a test notification, sent at Mon, Jul 11, 00:23.

This revision is now accepted and ready to land.Jul 11 2016, 02:51
Closed by commit rNOTIF544a5b2b7d01: Fix getObjectType and getProjectsPHIDs exceptions (authored by dereckson, committed by dereckson). · Explain WhyJul 11 2016, 02:51
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
app/
Phabricator/
8 lines

Diff 1187

View Options

app/Phabricator/PhabricatorStory.php

Loading...
Nasqueron DevCentral · If it had been much bigger the moon would have had a core of ice. · Powered by Phabricator