Page MenuHomeDevCentral

Refactor application
ClosedPublic

Authored by dereckson on Jul 11 2016, 14:10.
Tags
None
Referenced Files
F3783009: D507.id1225.diff
Tue, Nov 26, 01:44
F3783008: D507.id1224.diff
Tue, Nov 26, 01:44
F3782361: D507.id.diff
Tue, Nov 26, 00:15
F3781929: D507.diff
Mon, Nov 25, 22:26
Unknown Object (File)
Sat, Nov 23, 22:10
Unknown Object (File)
Wed, Nov 13, 05:29
Unknown Object (File)
Tue, Nov 12, 06:33
Unknown Object (File)
Mon, Nov 11, 03:08
Subscribers
None

Details

Summary

Reduced cyclomatic complexity replacing litany of if
by dictionaries and each combo.

Added code comments to give a structure to the file and ease navigation.

Split methods.

Better adherence to the Ruby community style guide.

Ref T912

Test Plan

Run application and check dashboard still prints correctly

Diff Detail

Repository
rTOMMY Tommy
Lint
Lint Warnings
SeverityLocationCodeMessage
Warningtommy.rb:55Metrics/AbcSizeRuboCop
Warningtommy.rb:55Metrics/MethodLengthRuboCop
Unit
No Test Coverage
Branch
refactoring
Build Status
Buildable 709
Build 832: arc lint + arc unit

Event Timeline

dereckson retitled this revision from to Refactor application.
dereckson updated this object.
dereckson edited the test plan for this revision. (Show Details)
This revision is now accepted and ready to land.Jul 11 2016, 14:11
This revision was automatically updated to reflect the committed changes.