Refactor application
ClosedPublic
Actions

Authored by dereckson on Jul 11 2016, 14:10.

Tags

None

Referenced Files

	F12371875: D507.diff
	Thu, Oct 30, 13:36

	F12371299: D507.diff
	Thu, Oct 30, 12:09

	Unknown Object (File)
	Tue, Oct 28, 18:45

	Unknown Object (File)
	Tue, Oct 28, 18:35

	Unknown Object (File)
	Tue, Oct 28, 03:24

	Unknown Object (File)
	Sat, Oct 25, 16:34

	Unknown Object (File)
	Sun, Oct 19, 08:02

	Unknown Object (File)
	Sat, Oct 18, 14:54

View All Files

Subscribers

None

Details

Reviewers

dereckson

Maniphest Tasks

T912: Follow the community Ruby Style Guide

Commits

rTOMMYfe5b06f19349: Refactor application

Summary

Reduced cyclomatic complexity replacing litany of if
by dictionaries and each combo.

Added code comments to give a structure to the file and ease navigation.

Split methods.

Better adherence to the Ruby community style guide.

Ref T912

Test Plan

Run application and check dashboard still prints correctly

Diff Detail

Repository

rTOMMY Tommy

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dereckson updated this revision to Diff 1224.Jul 11 2016, 14:10

dereckson retitled this revision from to Refactor application.

dereckson updated this object.

dereckson edited the test plan for this revision. (Show Details)

dereckson added a task: T912: Follow the community Ruby Style Guide.

dereckson accepted this revision.Jul 11 2016, 14:11

dereckson added a reviewer: dereckson.

This revision is now accepted and ready to land.Jul 11 2016, 14:11

Closed by commit rTOMMYfe5b06f19349: Refactor application (authored by dereckson, committed by dereckson). · Explain WhyJul 11 2016, 14:12

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

tommy.rb

137 lines

Diff 1225

View Options

Refactor applicationClosedPublicActions