Page MenuHomeDevCentral

ItemGroupMapping generic class
ClosedPublic

Authored by dereckson on Aug 22 2016, 20:28.
Tags
None
Referenced Files
F3767249: D627.diff
Fri, Nov 22, 23:11
F3766243: D627.id.diff
Fri, Nov 22, 17:15
Unknown Object (File)
Tue, Nov 19, 13:40
Unknown Object (File)
Tue, Nov 19, 12:40
Unknown Object (File)
Tue, Nov 19, 06:55
Unknown Object (File)
Tue, Nov 19, 05:05
Unknown Object (File)
Mon, Nov 18, 22:09
Unknown Object (File)
Mon, Nov 18, 19:56
Subscribers

Details

Summary

We're mapping Jenkins jobs / GitHub repositories/ Phabricator projects
to notifications group.

Instead to use a specific class to deserialize the service config file,
it's more convenient to introduce an ItemGroupMapping generic class.

To add new services, which follows the same pattern than Jenkins
or GitHub, ie match names of something and groups and allow *,
we can use the ItemGroupMapping class directly.

When there is a need to extend the format to allow more mapping
properties, we can extend the class, like in PhabricatorGroupMapping.

Test Plan
  • Fire GitHub / Docker / Phabricator notifications
  • Rebase Jenkins D626 against this code to use ItemGroupMapping too

Diff Detail

Repository
rNOTIF Notifications center
Lint
Lint Passed
Unit
Tests Passed
Branch
refactor-mapping

Event Timeline

dereckson retitled this revision from to ItemGroupMapping generic class.
dereckson updated this object.
dereckson edited the test plan for this revision. (Show Details)
dereckson added a reviewer: dereckson.
dereckson edited edge metadata.
This revision is now accepted and ready to land.Aug 22 2016, 20:55
This revision was automatically updated to reflect the committed changes.