Page MenuHomeDevCentral
Differential D747

Support GitHub pull request event
ClosedPublic
Actions

Authored by dereckson on Dec 13 2016, 16:46.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 22, 04:50
Unknown Object (File)
Tue, Dec 17, 04:46
Unknown Object (File)
Sun, Dec 15, 23:52
Unknown Object (File)
Thu, Dec 12, 14:51
Unknown Object (File)
Wed, Dec 11, 14:18
Unknown Object (File)
Wed, Dec 11, 14:18
Unknown Object (File)
Wed, Dec 11, 14:18
Unknown Object (File)
Wed, Dec 11, 14:18
View All Files
Subscribers
alken-orin

Details

Reviewers
dereckson
Commits
rNOTIF50b0f14901f6: Support GitHub pull request event
Test Plan

Unit tests are provided.

Fire a real payload and ensure the expected notification is fired.

Diff Detail

Repository
rNOTIF Notifications center
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dereckson updated this revision to Diff 1874.Dec 13 2016, 16:46
dereckson retitled this revision from to WIP: Support GitHub pull request event.
dereckson updated this object.
dereckson edited the test plan for this revision. (Show Details)
dereckson added a reviewer: dereckson.
alken-orin added a subscriber: alken-orin.Dec 13 2016, 16:52

Build is green https://ci.nasqueron.org/job/test-notifications-phab/218/ for more details.

dereckson updated this revision to Diff 1904.Dec 19 2016, 21:20
dereckson edited edge metadata.

+assigned

alken-orin added a comment.Dec 19 2016, 21:26

Build is green https://ci.nasqueron.org/job/test-notifications-phab/221/ for more details.

dereckson updated this revision to Diff 1905.Dec 19 2016, 21:54

Virtually complete, but let's see if we can add labels.

alken-orin added a comment.Dec 19 2016, 21:58

Build is green https://ci.nasqueron.org/job/test-notifications-phab/222/ for more details.

dereckson accepted this revision.Dec 20 2016, 11:27
dereckson retitled this revision from WIP: Support GitHub pull request event to Support GitHub pull request event.
dereckson edited edge metadata.
In D747#11484, @dereckson wrote:

Virtually complete, but let's see if we can add labels.

Payload doesn't include any new/removed labels, only a ''labeled'' or ''unlabeled'' action, that's not helpful.

So we're merging this without labels, and we'll revisit labels later.

This revision is now accepted and ready to land.Dec 20 2016, 11:29
Closed by commit rNOTIF50b0f14901f6: Support GitHub pull request event (authored by dereckson, committed by dereckson). · Explain WhyDec 20 2016, 11:29
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
app/
Analyzers/
GitHub/
Events/
91 lines
resources/
lang/
en/
12 lines
tests/
Analyzers/
GitHub/
Events/
5 lines
50 lines
data/
payloads/
GitHubEvents/
470 lines

Diff 1913

View Options

app/Analyzers/GitHub/Events/PullRequestEvent.php

Loading...
View Options

resources/lang/en/GitHub.php

Loading...
View Options

tests/Analyzers/GitHub/Events/EventTest.php

Loading...
View Options

tests/Analyzers/GitHub/Events/PullRequestEventTest.php

Loading...
View Options

tests/data/payloads/GitHubEvents/pull_request.json

Loading...
Nasqueron DevCentral · If it had been much bigger the moon would have had a core of ice. · Powered by Phabricator