As the notifications center now uses PHP 7.1,
we so switch to the relevant PHP 7 base image.
Fixes composer issue as it tries to validate dependencies
requirements for dev, even when --no-dev is passed.
Ref T1062.
Details
Details
- Reviewers
dereckson - Maniphest Tasks
- T1062: Upgrade notifications center code base to PHP 7
- Commits
- rDNOTIF24483e8a20db: Upgrade to PHP 7.1
Rebuild the container: docker build -t nasqueron/notifications .
Run tests.
Diff Detail
Diff Detail
- Repository
- rDNOTIF Notifications center Docker image
- Lint
No Lint Coverage - Unit
No Test Coverage - Branch
- arcpatch-D782
- Build Status
Buildable 1196 Build 1438: arc lint + arc unit
Event Timeline
Comment Actions
It seems the Composer --no-dev argument is ignored.
$ docker build -t nasqueron/notifications . Step 5 : RUN git init && git remote add origin https://github.com/nasqueron/notifications.git && git fetch && git checkout -t origin/master && composer install --no-dev -o && chown -R app:app /var/wwwroot/default ---> Running in 26c9c9ce041a Initialized empty Git repository in /var/wwwroot/default/.git/ From https://github.com/nasqueron/notifications * [new branch] master -> origin/master Already on 'master' Branch master set up to track remote branch master from origin. Do not run Composer as root/super user! See https://getcomposer.org/root for details Loading composer repositories with package information Updating dependencies Your requirements could not be resolved to an installable set of packages. Problem 1 - Installation request for etsy/phan dev-master -> satisfiable by etsy/phan[dev-master]. - etsy/phan dev-master requires ext-ast * -> the requested PHP extension ast is missing from your system.
Comment Actions
Container
$ cd /opt $ git clone https://github.com/nikic/php-ast $ cd php-ast && phpize && ./configure && make && make install $ echo 'extension=ast.so' > /usr/local/etc/php/conf.d/ast.ini $ cd /var/wwwroot/default $ composer install $ php artisan config:clear Configuration cache cleared! $ php artisan cache:clear Cache cleared successfully. $ vendor/bin/phpunit PHPUnit 4.8.31 by Sebastian Bergmann and contributors. Warning: The Xdebug extension is not loaded No code coverage will be generated. ............................................................... 63 / 181 ( 34%) ................I...I.......................................... 126 / 181 ( 69%) ....................................................... Time: 5.08 seconds, Memory: 34.00MB OK, but incomplete, skipped, or risky tests! Tests: 181, Assertions: 328, Incomplete: 2.