Maniphest T1062

Upgrade notifications center code base to PHP 7
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	dereckson
	Dec 18 2016, 12:41

Tags

Referenced Files

None

Subscribers

Description

Initial code was written in PHP 7, but then we wanted to release in a more universal 5.x.

Well, PHP 7.0 has been released 3 December 2015, and we currently didn't aggressively pushed the notifications center.

Furthermore, the notifications center isn't a small piece of software you decide to install on a random hosting, but a part of a more complex architecture, to use with a broker, and probably consumers (write-only notifications not consumed by any software isn't valuable). That means we can more reasonably ask the service to call the requirements, not the other way.

Plan

Document scalar parameters expected types
Add return type declarations
Use strict types, see https://wiki.php.net/rfc/scalar_type_hints_v5

Revisions and Commits

rNOTIF Notifications center
	Audited	D784	rNOTIF5ea27e48acb2 Declare explicitely return types
		D780	rNOTIF5c41373c9e2b Improve type documentation: Traversable\|array → iterable
		D753	rNOTIF22c6596059eb Upgrade code to PHP 7.1
rDNOTIF Notifications center Docker image
		D782	rDNOTIF24483e8a20db Upgrade to PHP 7.1

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		None	T1062 Upgrade notifications center code base to PHP 7
		Resolved		dereckson	T1064 Handle TypeError exceptions in ProjectsMapTest

Event Timeline

dereckson created this task.Dec 18 2016, 12:41

dereckson updated the task description. (Show Details)Dec 18 2016, 13:30

dereckson updated the task description. (Show Details)Dec 18 2016, 14:06

dereckson created subtask T1064: Handle TypeError exceptions in ProjectsMapTest.Dec 18 2016, 19:58

dereckson added a revision: D753: Upgrade code to PHP 7.1.Dec 19 2016, 00:37

dereckson moved this task from Backlog to Needs Review / Blocked / Waiting on the Notifications center (No, this is not a magic elixir, this is a fir distillate.) board.Dec 19 2016, 01:01

dereckson moved this task from Needs Review / Blocked / Waiting to In progress on the Notifications center (No, this is not a magic elixir, this is a fir distillate.) board.

dereckson moved this task from In progress to Backlog on the Notifications center (No, this is not a magic elixir, this is a fir distillate.) board.

dereckson moved this task from Backlog to Next on the Notifications center (No, this is not a magic elixir, this is a fir distillate.) board.Dec 25 2016, 12:18

dereckson closed subtask T1064: Handle TypeError exceptions in ProjectsMapTest as Resolved.Dec 25 2016, 18:54

dereckson added a commit: rNOTIF22c6596059eb: Upgrade code to PHP 7.1.

dereckson moved this task from Next to In progress on the Notifications center (No, this is not a magic elixir, this is a fir distillate.) board.Dec 30 2016, 03:26

dereckson added a revision: D780: Improve type documentation: Traversable|array → iterable.Dec 30 2016, 03:59

dereckson added a commit: rNOTIF5c41373c9e2b: Improve type documentation: Traversable|array → iterable.Dec 30 2016, 04:20

dereckson added a revision: D782: Upgrade to PHP 7.1.Dec 30 2016, 05:09

dereckson added a commit: rDNOTIF24483e8a20db: Upgrade to PHP 7.1.Dec 31 2016, 03:41

dereckson added a revision: D784: Declare explicitely return types.Dec 31 2016, 21:44

dereckson closed this task as Resolved by committing rNOTIF5ea27e48acb2: Declare explicitely return types.Dec 31 2016, 21:53

dereckson added a commit: rNOTIF5ea27e48acb2: Declare explicitely return types.