HomeDevCentral

Declare explicitely return types

Description

Declare explicitely return types

Summary:
This commit allows us to consider this code base to be PHP 7.

To explicitly declare return type and non object parameters
allow us to be sure code documentation is up to date and tell
the truth, and to allow to detect regression immediately in
the future. That improves codebase quality.

Phabricator is currently left alone, as we need to refactor
this part of the code. We'll add return type as part of the
refactoring.

Fixes T1062.

Test Plan:
The code touched is the part of code base with full code coverage.
Tests was run at each iteration to detect type issues.

Reviewers: dereckson

Subscribers: alken-orin

Maniphest Tasks: T1062

Differential Revision: https://devcentral.nasqueron.org/D784

Details

Auditors
dereckson
Provenance
derecksonAuthored on Dec 31 2016, 20:34
Differential Revision
D784: Declare explicitely return types
Parents
rNOTIF62a8792ac816: Improve code guidelines for exception handler
Branches
Unknown
Tags
Unknown
Tasks
T1062: Upgrade notifications center code base to PHP 7