Paths

Table of Contentst

Differential D785

Report current configuration state
ClosedPublic
Actions

Authored by dereckson on Jan 1 2017, 00:09.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Nov 12, 18:39

	Unknown Object (File)
	Mon, Nov 11, 15:33

	Unknown Object (File)
	Mon, Nov 11, 13:48

	Unknown Object (File)
	Mon, Nov 11, 07:35

	Unknown Object (File)
	Mon, Nov 11, 06:47

	Unknown Object (File)
	Mon, Nov 11, 01:49

	Unknown Object (File)
	Sun, Nov 10, 11:17

	Unknown Object (File)
	Sun, Nov 10, 07:42

Subscribers

Details

Reviewers

Maniphest Tasks

T663: Production environment tests for Notifications center
T1066: Report current configuration state

Commits

rNOTIFf3fcf394ac9c: Report current configuration state

Summary

Configuration status code is refactored to be a stand alone class.

This class will have two consumers:

/config shows a JSON representation of this class, implemented by this commit
config:show artisan command will use this class and Nasqueron\Notifications\Console\Commands\ConfigShow will only take care to display the configuration, that will be implemented in a follow-up commit

Fixes T1066.

Test Plan

Run tests for artisan config:show
Write new tests for /config route
Parse in rTESTSPRODENV (ref T663)

Diff Detail

Repository

rNOTIF Notifications center

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dereckson created this revision.Jan 1 2017, 00:09

Build has FAILED

Link to build: https://ci.nasqueron.org/job/test-notifications-phab/248/
See console output for more information: https://ci.nasqueron.org/job/test-notifications-phab/248/console

Draft code for report builder

Build has FAILED

Link to build: https://ci.nasqueron.org/job/test-notifications-phab/249/
See console output for more information: https://ci.nasqueron.org/job/test-notifications-phab/249/console

Working prototype

Build has FAILED

Link to build: https://ci.nasqueron.org/job/test-notifications-phab/250/
See console output for more information: https://ci.nasqueron.org/job/test-notifications-phab/250/console

dereckson mentioned this in D786: Move Features to Nasqueron\Notifications\Config namespace.Jan 1 2017, 02:42

dereckson mentioned this in rNOTIFf4c7321c99d6: Move Features to Nasqueron\Notifications\Config namespace.Jan 1 2017, 02:50

Rebase against Config namespace

Rebased

That will be for config-integration

dereckson retitled this revision from WIP: Report current configuration state to Report current configuration state.Jan 1 2017, 03:55

dereckson edited the summary of this revision. (Show Details)

dereckson accepted this revision.Jan 1 2017, 04:06

dereckson edited the summary of this revision. (Show Details)

dereckson edited edge metadata.

This revision is now accepted and ready to land.Jan 1 2017, 04:06

Closed by commit rNOTIFf3fcf394ac9c: Report current configuration state (authored by dereckson, committed by dereckson). · Explain WhyJan 1 2017, 04:09

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

app/

Config/

Reporting/

ConfigReport.php

79 lines

FeatureReportEntry.php

36 lines

ServiceReportEntry.php

102 lines

Http/

9 lines

config/

3 lines

Diff 1996

app/Config/Reporting/ConfigReport.php

Loading...

app/Config/Reporting/FeatureReportEntry.php

Loading...

app/Config/Reporting/ServiceReportEntry.php

Loading...

app/Http/routes.php

Loading...

config/app.php

Loading...