Reload nginx after any configuration file is updated
ClosedPublic
Actions

Authored by dereckson on Apr 20 2017, 08:15.

Details

Reviewers

jokerozen
Sandlayth
dereckson

Maniphest Tasks

T1185: Restart nginx when configuration sls are amended on Eglide

Commits

rOPS674d4e016732: Reload nginx after any configuration file is updated

Summary

Currently, only nginx.conf triggers a nginx reload.

Yet, we can add a new configuration file, e.g. for a new vhost
or amend an existing one, and that should trigger a reload too.

Fixes T1185.

Test Plan

Change configuration (e.g. D956) and ensure it works

Diff Detail

Repository

rOPS Nasqueron Operations

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dereckson created this revision.Apr 20 2017, 08:15

dereckson added a child revision: D956: Simplify unknown domain nginx configuration.Apr 20 2017, 08:25

When nothing changes

Salt master

$ salt eglide state.apply roles/shellserver/web-hosting/
[…]
----------
          ID: nginx_config_files
    Function: cmd.run
        Name: nginx -s reload
      Result: True
     Comment: State was not run because none of the onchanges reqs changed
     Changes:   
[…]

When a configuration file changes

Tested with D956:

Salt master

$ salt eglide state.apply roles/shellserver/web-hosting/
[…]
----------
          ID: nginx_config_files
    Function: cmd.run
        Name: nginx -s reload
      Result: True
     Comment: Command "nginx -s reload" run
     Started: 08:28:09.985663
    Duration: 76.968 ms
     Changes:   
              ----------
              pid:
                  19504
              retcode:
                  0
              stderr:
              stdout:
[…]