Differential D956

Simplify unknown domain nginx configuration
ClosedPublic
Actions

Authored by dereckson on Apr 20 2017, 08:23.

Details

Reviewers

dereckson

Commits

rOPS4a1eba2b1e9a: Simplify unknown domain nginx configuration

Summary

Avoid a rewrite, as we always serve the same unknown.html file

Test Plan

browse a domain pointing to the IP but not configured
ensure it's still serving unknown.html

Diff Detail

Repository

rOPS Nasqueron Operations

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dereckson created this revision.Apr 20 2017, 08:23

dereckson edited the summary of this revision. (Show Details)Apr 20 2017, 08:25

dereckson edited the test plan for this revision. (Show Details)

dereckson added a reviewer: dereckson.

dereckson added a parent revision: D955: Reload nginx after any configuration file is updated.

dereckson added subscribers: Sandlayth, jokerozen.

dereckson mentioned this in D955: Reload nginx after any configuration file is updated.Apr 20 2017, 08:32

Rebased against D955

On my local workstation, I asked "unknown" to point to Eglide IP:

/etc/hosts

# Debug
212.47.244.42 eglide.org
212.47.244.42 unknown
212.47.244.42 eglide.org

Then, I browsed and curl'ed http://unknown and http://unknown/foo.html to ensure it works (+ 404 code is returned).

This revision is now accepted and ready to land.Apr 20 2017, 08:37

dereckson mentioned this in rOPS674d4e016732: Reload nginx after any configuration file is updated.Apr 20 2017, 10:02

Closed by commit rOPS4a1eba2b1e9a: Simplify unknown domain nginx configuration (authored by dereckson, committed by dereckson). · Explain WhyApr 20 2017, 10:06

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

roles/

shellserver/

web-hosting/

files/

eglide/

nginx/

vhosts/

000.conf

9 lines

Diff 2441

View Options

roles/shellserver/web-hosting/files/eglide/nginx/vhosts/000.conf

Simplify unknown domain nginx configurationClosedPublicActions