Page MenuHomeDevCentral

Analyze The Japan Times
ClosedPublic

Authored by Thibaut120094 on Jun 16 2017, 21:26.

Diff Detail

Repository
rSTG Source templates generator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Thibaut120094 created this revision.Jun 16 2017, 21:26
dereckson requested changes to this revision.Jun 17 2017, 23:37

Looks good.

Note pages/index.dat chmod shouldn't change, as there isn't rationale to have an executable there

pages/thejapantimes.php
26

Whitespace issue.

Ident with 4 spaces (we need an automatic check for arc diff by the way for this one, ideally with an autofix offered).

This revision now requires changes to proceed.Jun 17 2017, 23:37
Thibaut120094 updated this revision to Diff 2548.Jul 5 2017, 17:21
Thibaut120094 edited edge metadata.

Fixed whitespace issues and chmod change.

Thibaut120094 marked an inline comment as done.Jul 5 2017, 17:47

Looks good to me.

dereckson requested changes to this revision.Jul 29 2017, 10:20
dereckson added inline comments.
pages/thejapantimes.php
25

Strict Standards: Only variables should be passed by reference in /usr/home/dereckson/dev/nasqueron/tools/3rdparty/source-templates-generator/pages/thejapantimes.php on line 24

This revision now requires changes to proceed.Jul 29 2017, 10:20
dereckson updated this revision to Diff 2566.Jul 30 2017, 12:50
dereckson edited edge metadata.

Use between for title

dereckson updated this revision to Diff 2567.Jul 30 2017, 12:51

Grammar

dereckson accepted this revision.Jul 30 2017, 12:52
This revision is now accepted and ready to land.Jul 30 2017, 12:52
This revision was automatically updated to reflect the committed changes.