Page MenuHomeDevCentral

Analyze The Japan Times
ClosedPublic

Authored by Thibaut120094 on Jun 16 2017, 21:26.
Tags
None
Referenced Files
F2746088: D997.id2548.diff
Fri, Mar 29, 01:34
F2745108: D997.diff
Thu, Mar 28, 21:32
F2743679: D997.vs2548.id2568.whitespaceignore-most.diff
Thu, Mar 28, 11:29
F2743110: D997.id2567.diff
Thu, Mar 28, 07:58
Unknown Object (File)
Wed, Mar 27, 22:42
Unknown Object (File)
Wed, Mar 27, 21:03
Unknown Object (File)
Wed, Mar 27, 20:38
Unknown Object (File)
Wed, Mar 27, 15:13
Subscribers
None

Diff Detail

Repository
rSTG Source templates generator
Lint
No Lint Coverage
Unit
No Test Coverage
Branch
site/thejapantimes
Build Status
Buildable 1556
Build 1804: arc lint + arc unit

Event Timeline

dereckson requested changes to this revision.Jun 17 2017, 23:37

Looks good.

Note pages/index.dat chmod shouldn't change, as there isn't rationale to have an executable there

pages/thejapantimes.php
26

Whitespace issue.

Ident with 4 spaces (we need an automatic check for arc diff by the way for this one, ideally with an autofix offered).

This revision now requires changes to proceed.Jun 17 2017, 23:37
Thibaut120094 edited edge metadata.

Fixed whitespace issues and chmod change.

dereckson requested changes to this revision.Jul 29 2017, 10:20
dereckson added inline comments.
pages/thejapantimes.php
24

Strict Standards: Only variables should be passed by reference in /usr/home/dereckson/dev/nasqueron/tools/3rdparty/source-templates-generator/pages/thejapantimes.php on line 24

This revision now requires changes to proceed.Jul 29 2017, 10:20
dereckson edited edge metadata.

Use between for title

This revision is now accepted and ready to land.Jul 30 2017, 12:52
This revision was automatically updated to reflect the committed changes.