Page MenuHomeDevCentral

Style: better compliance with community Ruby coding style guide
ClosedPublic

Authored by dereckson on Jul 10 2016, 21:27.
Tags
None
Referenced Files
F10400267: D478.id1168.diff
Sat, Jul 5, 00:39
F10398458: D478.id1169.diff
Fri, Jul 4, 18:44
F10397716: D478.id.diff
Fri, Jul 4, 15:44
Unknown Object (File)
Fri, Jul 4, 11:47
Unknown Object (File)
Thu, Jul 3, 12:58
Unknown Object (File)
Fri, Jun 27, 00:53
Unknown Object (File)
Thu, Jun 26, 13:41
Unknown Object (File)
Mon, Jun 23, 05:47
Subscribers
None

Details

Summary

The following points, detected by Rubocop, are improved:

  • if !somethingunless something
  • Ruby 1.9 hash syntax is used
  • is_quality?quality?
  • removed extraneous self
Test Plan

Run dashboard, ensure all cards are still available.

Diff Detail

Repository
rTOMMY Tommy
Lint
Lint Warnings
SeverityLocationCodeMessage
Warningtommy.rb:32Metrics/LineLengthRuboCop
Warningtommy.rb:33Metrics/LineLengthRuboCop
Warningtommy.rb:35Metrics/LineLengthRuboCop
Warningtommy.rb:36Metrics/LineLengthRuboCop
Unit
No Test Coverage
Branch
style (branched from master)
Build Status
Buildable 678
Build 798: arc lint + arc unit

Event Timeline

dereckson retitled this revision from to Style: better compliance with community Ruby coding style guide.
dereckson updated this object.
dereckson edited the test plan for this revision. (Show Details)
dereckson added a reviewer: dereckson.
dereckson edited edge metadata.
This revision is now accepted and ready to land.Jul 10 2016, 21:28
This revision was automatically updated to reflect the committed changes.