Page MenuHomeDevCentral

Refactor application
ClosedPublic

Authored by dereckson on Jul 11 2016, 14:10.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jan 23, 07:25
Unknown Object (File)
Wed, Jan 22, 10:57
Unknown Object (File)
Fri, Jan 17, 10:57
Unknown Object (File)
Fri, Jan 17, 04:46
Unknown Object (File)
Wed, Jan 15, 07:26
Unknown Object (File)
Sat, Dec 28, 05:01
Unknown Object (File)
Sat, Dec 28, 05:01
Unknown Object (File)
Sat, Dec 28, 04:35
Subscribers
None

Details

Summary

Reduced cyclomatic complexity replacing litany of if
by dictionaries and each combo.

Added code comments to give a structure to the file and ease navigation.

Split methods.

Better adherence to the Ruby community style guide.

Ref T912

Test Plan

Run application and check dashboard still prints correctly

Diff Detail

Repository
rTOMMY Tommy
Lint
Lint Warnings
SeverityLocationCodeMessage
Warningtommy.rb:55Metrics/AbcSizeRuboCop
Warningtommy.rb:55Metrics/MethodLengthRuboCop
Unit
No Test Coverage
Branch
refactoring
Build Status
Buildable 709
Build 832: arc lint + arc unit

Event Timeline

dereckson retitled this revision from to Refactor application.
dereckson updated this object.
dereckson edited the test plan for this revision. (Show Details)
This revision is now accepted and ready to land.Jul 11 2016, 14:11
This revision was automatically updated to reflect the committed changes.