Page MenuHomeDevCentral

Support GitHub pull request event
ClosedPublic

Authored by dereckson on Dec 13 2016, 16:46.
Tags
None
Referenced Files
F10442537: D747.id.diff
Mon, Jul 7, 17:40
F10432173: D747.id1905.diff
Mon, Jul 7, 15:27
F10429394: D747.id1904.diff
Mon, Jul 7, 13:45
Unknown Object (File)
Mon, Jul 7, 11:31
Unknown Object (File)
Mon, Jul 7, 05:54
Unknown Object (File)
Sun, Jul 6, 09:44
Unknown Object (File)
Sun, Jul 6, 00:21
Unknown Object (File)
Fri, Jul 4, 16:37
Subscribers

Details

Test Plan

Unit tests are provided.

Fire a real payload and ensure the expected notification is fired.

Diff Detail

Repository
rNOTIF Notifications center
Lint
Lint Passed
Unit
Tests Passed
Branch
github-pull-request (branched from master)

Event Timeline

dereckson retitled this revision from to WIP: Support GitHub pull request event.
dereckson updated this object.
dereckson edited the test plan for this revision. (Show Details)
dereckson added a reviewer: dereckson.
dereckson edited edge metadata.

+assigned

Virtually complete, but let's see if we can add labels.

dereckson retitled this revision from WIP: Support GitHub pull request event to Support GitHub pull request event.
dereckson edited edge metadata.

Virtually complete, but let's see if we can add labels.

Payload doesn't include any new/removed labels, only a ''labeled'' or ''unlabeled'' action, that's not helpful.

So we're merging this without labels, and we'll revisit labels later.

This revision is now accepted and ready to land.Dec 20 2016, 11:29
This revision was automatically updated to reflect the committed changes.