Page MenuHomeDevCentral
Differential D785

Report current configuration state
ClosedPublic
Actions

Authored by dereckson on Jan 1 2017, 00:09.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Dec 16, 06:02
Unknown Object (File)
Mon, Dec 16, 05:50
Unknown Object (File)
Mon, Dec 16, 04:32
Unknown Object (File)
Fri, Dec 13, 21:39
Unknown Object (File)
Fri, Dec 13, 10:13
Unknown Object (File)
Fri, Dec 13, 05:52
Unknown Object (File)
Thu, Dec 12, 23:49
Unknown Object (File)
Wed, Dec 11, 10:06
View All Files
Subscribers
alken-orin

Details

Reviewers
dereckson
Maniphest Tasks
T663: Production environment tests for Notifications center
T1066: Report current configuration state
Commits
rNOTIFf3fcf394ac9c: Report current configuration state
Summary

Configuration status code is refactored to be a stand alone class.

This class will have two consumers:

  • /config shows a JSON representation of this class, implemented by this commit
  • config:show artisan command will use this class and Nasqueron\Notifications\Console\Commands\ConfigShow will only take care to display the configuration, that will be implemented in a follow-up commit

Fixes T1066.

Test Plan
  • Run tests for artisan config:show
  • Write new tests for /config route
  • Parse in rTESTSPRODENV (ref T663)

Diff Detail

Repository
rNOTIF Notifications center
Lint
Lint Passed
Unit
No Test Coverage
Branch
config (branched from master)

Event Timeline

dereckson created this revision.Jan 1 2017, 00:09
alken-orin added a subscriber: alken-orin.Jan 1 2017, 00:10

Build has FAILED

Link to build: https://ci.nasqueron.org/job/test-notifications-phab/248/
See console output for more information: https://ci.nasqueron.org/job/test-notifications-phab/248/console

dereckson updated this revision to Diff 1985.Jan 1 2017, 00:49
dereckson edited edge metadata.

Draft code for report builder

alken-orin added a comment.Jan 1 2017, 00:51

Build has FAILED

Link to build: https://ci.nasqueron.org/job/test-notifications-phab/249/
See console output for more information: https://ci.nasqueron.org/job/test-notifications-phab/249/console

dereckson updated this revision to Diff 1986.Jan 1 2017, 02:36

Working prototype

alken-orin added a comment.Jan 1 2017, 02:38

Build has FAILED

Link to build: https://ci.nasqueron.org/job/test-notifications-phab/250/
See console output for more information: https://ci.nasqueron.org/job/test-notifications-phab/250/console

dereckson mentioned this in D786: Move Features to Nasqueron\Notifications\Config namespace.Jan 1 2017, 02:42
dereckson mentioned this in rNOTIFf4c7321c99d6: Move Features to Nasqueron\Notifications\Config namespace.Jan 1 2017, 02:50
dereckson updated this revision to Diff 1991.Jan 1 2017, 03:07

Rebase against Config namespace

dereckson updated this revision to Diff 1994.Jan 1 2017, 03:42

Rebased

dereckson updated this revision to Diff 1995.Jan 1 2017, 03:49

That will be for config-integration

dereckson retitled this revision from WIP: Report current configuration state to Report current configuration state.Jan 1 2017, 03:55
dereckson edited the summary of this revision. (Show Details)
dereckson accepted this revision.Jan 1 2017, 04:06
dereckson edited the summary of this revision. (Show Details)
dereckson edited edge metadata.
This revision is now accepted and ready to land.Jan 1 2017, 04:06
Closed by commit rNOTIFf3fcf394ac9c: Report current configuration state (authored by dereckson, committed by dereckson). · Explain WhyJan 1 2017, 04:09
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
app/
Config/
Reporting/
79 lines
37 lines
102 lines
Http/
9 lines
config/
3 lines
tests/
data/
32 lines

Diff 1986

View Options

app/Config/Reporting/ConfigReport.php

Loading...
View Options

app/Config/Reporting/FeatureReportEntry.php

Loading...
View Options

app/Config/Reporting/ServiceReportEntry.php

Loading...
View Options

app/Http/routes.php

Loading...
View Options

config/app.php

Loading...
View Options

tests/data/config.json

Loading...
Nasqueron DevCentral · If it had been much bigger the moon would have had a core of ice. · Powered by Phabricator