Page MenuHomeDevCentral

Analyze The Japan Times
ClosedPublic

Authored by Thibaut120094 on Jun 16 2017, 21:26.
Tags
None
Referenced Files
F3764577: D997.id2567.diff
Fri, Nov 22, 06:48
F3764488: D997.id2568.diff
Fri, Nov 22, 06:07
F3764473: D997.id2548.diff
Fri, Nov 22, 06:02
F3764450: D997.id2546.diff
Fri, Nov 22, 05:54
F3762757: D997.diff
Thu, Nov 21, 14:50
F3762756: D997.diff
Thu, Nov 21, 14:50
Unknown Object (File)
Tue, Nov 19, 09:08
Unknown Object (File)
Mon, Nov 18, 21:47
Subscribers
None

Diff Detail

Repository
rSTG Source templates generator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dereckson requested changes to this revision.Jun 17 2017, 23:37

Looks good.

Note pages/index.dat chmod shouldn't change, as there isn't rationale to have an executable there

pages/thejapantimes.php
26

Whitespace issue.

Ident with 4 spaces (we need an automatic check for arc diff by the way for this one, ideally with an autofix offered).

This revision now requires changes to proceed.Jun 17 2017, 23:37
Thibaut120094 edited edge metadata.

Fixed whitespace issues and chmod change.

dereckson requested changes to this revision.Jul 29 2017, 10:20
dereckson added inline comments.
pages/thejapantimes.php
25

Strict Standards: Only variables should be passed by reference in /usr/home/dereckson/dev/nasqueron/tools/3rdparty/source-templates-generator/pages/thejapantimes.php on line 24

This revision now requires changes to proceed.Jul 29 2017, 10:20
dereckson edited edge metadata.

Use between for title

This revision is now accepted and ready to land.Jul 30 2017, 12:52
This revision was automatically updated to reflect the committed changes.