Page MenuHomeDevCentral

Improve Arcanist shell scripts
ClosedPublic

Authored by dereckson on Oct 25 2017, 02:34.
Tags
None
Referenced Files
F10836982: D1118.id.diff
Mon, Jul 28, 11:30
F10836167: D1118.id2854.diff
Mon, Jul 28, 10:31
F10818007: D1118.diff
Sun, Jul 27, 16:55
Unknown Object (File)
Fri, Jul 25, 20:28
Unknown Object (File)
Fri, Jul 11, 23:02
Unknown Object (File)
Sat, Jul 5, 06:14
Unknown Object (File)
Sat, Jul 5, 01:15
Unknown Object (File)
Fri, Jul 4, 22:34
Subscribers
None

Details

Summary

Fixes suggested by shellcheck:

  • use $() instead of deprecated ``
  • avoid cat when pipelines can be used
  • quote variables
Test Plan

shellcheck

Diff Detail

Repository
rWK Wynter Kitro utilities
Lint
Lint Passed
SeverityLocationCodeMessage
Advicearcanist/arc-paste-file.sh:16SC2094SHELLCHECK
Advicearcanist/arc-paste-file.sh:16SC2094SHELLCHECK
Unit
No Test Coverage
Branch
shellcheck (branched from master)
Build Status
Buildable 1760
Build 2008: arc lint + arc unit

Event Timeline

We're sure it only reads.

This revision is now accepted and ready to land.Oct 25 2017, 02:35
This revision was automatically updated to reflect the committed changes.