Add shellcheck linter
ClosedPublic
Actions

Authored by dereckson on Nov 3 2017, 18:24.

Tags

Referenced Files

	Unknown Object (File)
	Sat, Aug 16, 23:58

	Unknown Object (File)
	Sat, Aug 16, 08:35

	Unknown Object (File)
	Sat, Aug 16, 07:28

	Unknown Object (File)
	Sat, Aug 9, 20:53

	Unknown Object (File)
	Sat, Aug 9, 14:45

	Unknown Object (File)
	Wed, Aug 6, 02:46

	Unknown Object (File)
	Tue, Aug 5, 15:35

	Unknown Object (File)
	Tue, Aug 5, 10:02

View All Files

Subscribers

Nasqueron Docker deployment squad

Details

Reviewers

dereckson

Commits

rDARC05c2c83f7a93: Add shellcheck linter

Summary

Setup similar to rOPSf637b1b858173

Test Plan

arc lint

Diff Detail

Repository

rDARC nasqueron/arcanist Docker image

Lint

No Lint Coverage

Unit

No Test Coverage

Branch

shellcheck (branched from master)

Build Status

Buildable 1829
Build 2077: arc lint + arc unit

Event Timeline

dereckson created this revision.Nov 3 2017, 18:24

Herald added a project: Docker images. · View Herald TranscriptNov 3 2017, 18:24

Herald added a subscriber: Nasqueron Docker deployment squad. · View Herald Transcript

Harbormaster completed remote builds in B1829: Diff 2971.Nov 3 2017, 18:24

Works fine:

$ cat > foo.sh
#!/bin/sh

foo $1
$ git add foo.sh 
$ arc lint
>>> Lint for foo.sh:


   Advice  (SC2086) SHELLCHECK
    Double quote to prevent globbing and word splitting.

               1 #!/bin/sh
               2 
    >>>        3 foo $1
                     ^
 OKAY  No lint warnings.