Paths

Table of Contentst

Use consistent behavior between pubm:log and pub:log/dcc:log
ClosedPublic
Actions

Authored by dereckson on Mar 3 2018, 01:25.

Tags

None

Referenced Files

	F21002412: D1389.diff
	Wed, Jan 14, 06:37

	F20991807: D1389.id3545.diff
	Wed, Jan 14, 03:07

	F20985534: D1389.diff
	Wed, Jan 14, 00:55

	F20984535: D1389.id.diff
	Wed, Jan 14, 00:32

	Unknown Object (File)
	Sun, Jan 11, 09:59

	Unknown Object (File)
	Thu, Jan 1, 15:03

	Unknown Object (File)
	Mon, Dec 29, 12:45

	Unknown Object (File)
	Sun, Dec 28, 13:50

View All Files

Subscribers

None

Details

Reviewers

dereckson

Commits

rVIPER4349adfcb2f4: Use consistent behavior between pubm:log and pub:log/dcc:log

Summary

Sure, pubm:log has already identified the component and the entry,
but this is not a valid reason to violate SRP and make this hard
to maintain.

An hint it's a bad idea? former code used $emitter, which isn't defined.

Test Plan

Tested all day on #nasqueron-ops

Diff Detail

Repository

rVIPER ViperServ scripts

Lint

No Lint Coverage

Unit

No Test Coverage

Branch

serverslog (branched from master)

Build Status

Buildable 2179
Build 2427: arc lint + arc unit

Event Timeline

dereckson requested review of this revision.Mar 3 2018, 01:25

dereckson created this revision.

Harbormaster completed remote builds in B2179: Diff 3545.Mar 3 2018, 01:25

dereckson accepted this revision.Mar 3 2018, 01:25

dereckson edited the test plan for this revision. (Show Details)

This revision is now accepted and ready to land.Mar 3 2018, 01:25

Closed by commit rVIPER4349adfcb2f4: Use consistent behavior between pubm:log and pub:log/dcc:log (authored by dereckson). · Explain WhyMar 3 2018, 01:25

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

Wearg/

ServersLog.tcl

3 lines

Diff 3545

View Options

Use consistent behavior between pubm:log and pub:log/dcc:logClosedPublicActions