Page MenuHomeDevCentral

Prune never executed code
ClosedPublic

Authored by dereckson on Jan 10 2016, 01:50.
Tags
None
Referenced Files
F10406634: D214.id.diff
Sat, Jul 5, 18:52
F10406507: D214.id506.diff
Sat, Jul 5, 18:28
Unknown Object (File)
Sat, Jul 5, 11:49
Unknown Object (File)
Fri, Jul 4, 21:05
Unknown Object (File)
Fri, Jul 4, 03:49
Unknown Object (File)
Sat, Jun 28, 10:28
Unknown Object (File)
Sun, Jun 22, 00:51
Unknown Object (File)
Sun, Jun 22, 00:50
Subscribers

Details

Reviewers
dereckson
Commits
Unknown Object (Diffusion Commit)
rNOTIFbe0c324ed737: Prune never executed code
Summary

GitHubGateController::onPost contains an abort instruction.

This throws an exception, so return isn't needed.

This has been noticed look at the D213 test coverage.

Test Plan
  • Fire a GitHub valid payload
  • Fire a GitHub invalid payload
  • phpunit

Diff Detail

Repository
rNOTIF Notifications center
Lint
Lint Passed
Unit
No Test Coverage
Branch
controller-dead-code

Event Timeline

dereckson retitled this revision from to Prune never executed code.
dereckson updated this object.
dereckson edited the test plan for this revision. (Show Details)
dereckson added a reviewer: dereckson.
dereckson edited edge metadata.
This revision is now accepted and ready to land.Jan 10 2016, 02:07
This revision was automatically updated to reflect the committed changes.