Page MenuHomeDevCentral
Differential D219

GateController::logRequest refactoring
ClosedPublic
Actions

Authored by dereckson on Jan 11 2016, 17:32.
Tags
None
Referenced Files
F3750063: D219.id516.diff
Sat, Nov 16, 20:37
F3749911: D219.diff
Sat, Nov 16, 19:00
Unknown Object (File)
Wed, Nov 13, 13:47
Unknown Object (File)
Sun, Nov 10, 13:16
Unknown Object (File)
Sun, Nov 10, 06:47
Unknown Object (File)
Sat, Nov 9, 15:29
Unknown Object (File)
Sat, Nov 9, 13:03
Unknown Object (File)
Mon, Nov 4, 07:13
View All Files
Subscribers
alken-orin

Details

Reviewers
dereckson
Commits
Unknown Object (Diffusion Commit)
rNOTIFcc622917e76d: GateController::logRequest refactoring
Summary

Any gate without any specific requirement can call logRequest
without argument.

Other gates can pass an array with extra contextual data to log.

The log format doesn't change.

Test Plan

tail -n 10 -f storage/logs/laravel.log && phpunit

Diff Detail

Repository
rNOTIF Notifications center
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dereckson updated this revision to Diff 516.Jan 11 2016, 17:32
dereckson retitled this revision from to GateController::logRequest refactoring.
dereckson updated this object.
dereckson edited the test plan for this revision. (Show Details)
dereckson added a reviewer: dereckson.
alken-orin added a subscriber: alken-orin.Jan 11 2016, 17:32

Build started: https://ci.nasqueron.org/job/test-notifications-phab/11/ (console: https://ci.nasqueron.org/job/test-notifications-phab/11/console)

dereckson updated this revision to Diff 517.Jan 11 2016, 17:33
dereckson edited edge metadata.

Code documentation restored.

app/Http/Controllers/Gate/GitHubGateController.php
141–142

Comments to restore.

dereckson accepted this revision.Jan 11 2016, 17:34
dereckson marked an inline comment as done.
dereckson edited edge metadata.
This revision is now accepted and ready to land.Jan 11 2016, 17:34
alken-orin added a comment.Jan 11 2016, 17:34

Build is green https://ci.nasqueron.org/job/test-notifications-phab/11/ for more details.

alken-orin added a comment.Jan 11 2016, 17:34

Build started: https://ci.nasqueron.org/job/test-notifications-phab/12/ (console: https://ci.nasqueron.org/job/test-notifications-phab/12/console)

Closed by commit rNOTIFcc622917e76d: GateController::logRequest refactoring (authored by dereckson, committed by dereckson). · Explain WhyJan 11 2016, 17:35
This revision was automatically updated to reflect the committed changes.
alken-orin added a comment.Jan 11 2016, 17:36

Build is green https://ci.nasqueron.org/job/test-notifications-phab/12/ for more details.

dereckson added a comment.Jan 11 2016, 17:37

Test coverage. This change brings full coverage for GateController class.

dereckson mentioned this in D220: Prune not used namespaces..Jan 11 2016, 17:48
dereckson mentioned this in rNOTIF46a71ea7b2f3: Prune not used namespaces..Jan 11 2016, 17:52

Revision Contents
Changeset List

Diff 518

View Options

app/Http/Controllers/Gate/DockerHubGateController.php

Loading...
View Options

app/Http/Controllers/Gate/GateController.php

Loading...
View Options

app/Http/Controllers/Gate/GitHubGateController.php

Loading...
View Options

app/Http/Controllers/Gate/PhabricatorGateController.php

Loading...
Nasqueron DevCentral · If it had been much bigger the moon would have had a core of ice. · Powered by Phabricator