Differential D2284

Build local URL
ClosedPublic
Actions

Authored by dereckson on Mar 17 2020, 03:21.

Tags

None

Referenced Files

	F12377166: D2284.id5759.diff
	Fri, Oct 31, 04:16

	Unknown Object (File)
	Tue, Oct 28, 06:06

	Unknown Object (File)
	Tue, Oct 28, 06:06

	Unknown Object (File)
	Tue, Oct 28, 06:06

	Unknown Object (File)
	Tue, Oct 28, 05:16

	Unknown Object (File)
	Mon, Oct 27, 03:46

	Unknown Object (File)
	Mon, Oct 27, 03:46

	Unknown Object (File)
	Mon, Oct 27, 03:46

Subscribers

None

Details

Reviewers

Commits

rKOT06ffd53b1ecf: Build local URL

Summary

The Request class allows to build server URL
while the URL class allow to encode local part.

Let's combine the two to allow to build local URLs.

Test Plan

Unit test provided.

Diff Detail

Repository

rKOT Keruald OmniTools

Lint

Lint Errors

Severity	Location	Code	Message
Error	tests/HTTP/Requests/RequestTest.php:137	PHPCS.E.Generic.Files.LineLength.MaxExceeded	Generic.Files.LineLength.MaxExceeded
Warning	src/HTTP/Requests/WithURL.php:96	PHPCS.W.Generic.Files.LineLength.TooLong	Generic.Files.LineLength.TooLong

Unit

Tests Passed

Branch

arcpatch-D2284

Build Status

Buildable 3551
Build 3800: arc lint + arc unit

Event Timeline

dereckson requested review of this revision.Mar 17 2020, 03:21

dereckson created this revision.

dereckson added inline comments.Mar 18 2020, 02:34

src/HTTP/Requests/WithURL.php
102	Should work without this / Need to be fixed at URL level.

Rebase against / fix

Harbormaster completed remote builds in B3551: Diff 5759.Mar 18 2020, 02:37

dereckson accepted this revision.Mar 18 2020, 02:38

This revision is now accepted and ready to land.Mar 18 2020, 02:38

This revision was landed with ongoing or failed builds.Mar 18 2020, 02:38

Closed by commit rKOT06ffd53b1ecf: Build local URL (authored by dereckson). · Explain Why

This revision was automatically updated to reflect the committed changes.

dereckson added a commit: rKOT06ffd53b1ecf: Build local URL.

Revision Contents
Changeset List

Path

Size

src/

HTTP/

Requests/

15 lines

tests/

HTTP/

Requests/

RequestTest.php

18 lines

Diff 5759

src/HTTP/Requests/WithURL.php

Loading...

tests/HTTP/Requests/RequestTest.php

Loading...