ClosedPublic
Actions

Authored by dereckson on May 30 2020, 23:08.

Tags

None

Referenced Files

	F25381273: D2290.id.diff
	Sat, Apr 11, 09:31

	F25376944: D2290.diff
	Sat, Apr 11, 07:28

	Unknown Object (File)
	Fri, Apr 10, 09:24

	Unknown Object (File)
	Fri, Apr 10, 03:19

	Unknown Object (File)
	Tue, Apr 7, 20:54

	Unknown Object (File)
	Sun, Apr 5, 08:06

	Unknown Object (File)
	Thu, Apr 2, 19:24

	Unknown Object (File)
	Thu, Apr 2, 15:45

View All Files

Subscribers

None

Details

Reviewers

amj

Commits

rLFfe6f26f02319: Avoid Box<Vec<_>>

Summary

As Vec is already a smart pointer, there isn't any need or benefit
to encapsulate it into another smart pointer.

Test Plan

Run a microservice, the routes are mounted as before.

Diff Detail

Repository

rLF Limiting Factor

Lint

Lint Passed

Unit

No Test Coverage

Branch

fix-box-vec

Build Status

Buildable 3557
Build 3806: arc lint + arc unit

Event Timeline

dereckson requested review of this revision.May 30 2020, 23:08

dereckson created this revision.

Harbormaster completed remote builds in B3557: Diff 5768.May 30 2020, 23:08

for DefaultService too

Harbormaster completed remote builds in B3559: Diff 5770.May 31 2020, 00:00

amj accepted this revision.May 31 2020, 00:26

This revision is now accepted and ready to land.May 31 2020, 00:26

Closed by commit rLFfe6f26f02319: Avoid Box<Vec<_>> (authored by dereckson). · Explain WhyJun 1 2020, 17:31

This revision was automatically updated to reflect the committed changes.

dereckson added a commit: rLFfe6f26f02319: Avoid Box<Vec<_>>.

Revision Contents
Changeset List

Path

Size

src/

config.rs

2 lines

kernel.rs

2 lines

Diff 5768

View Options

src/config.rs