Differential D2503

Test HTML and Markdown outputs
ClosedPublic
Actions

Authored by dereckson on Feb 7 2022, 06:03.

Tags

None

Referenced Files

	F3744533: D2503.diff
	Fri, Nov 15, 06:33

	F3743589: D2503.diff
	Thu, Nov 14, 22:10

	F3742563: D2503.id6308.diff
	Thu, Nov 14, 08:08

	Unknown Object (File)
	Tue, Nov 12, 19:42

	Unknown Object (File)
	Tue, Nov 12, 11:43

	Unknown Object (File)
	Tue, Nov 12, 09:29

	Unknown Object (File)
	Tue, Nov 12, 04:38

	Unknown Object (File)
	Mon, Nov 11, 20:23

Subscribers

None

Details

Reviewers

Maniphest Tasks

T1678: Health check and reporting library

Commits

rKREPORTf6535b1db5d6: Test HTML and Markdown outputs

Summary

This change provides the classes architecture,
and the output tests.

Follow-up changes will provide concrete implementation.

Ref T1678.

Test Plan

Integration tests provided

Diff Detail

Repository

rKREPORT Keruald Report

Lint

Lint Warnings

Severity	Location	Code	Message
Warning	tests/WithSampleReport.php:21	PHPCS.W.Generic.Files.LineLength.TooLong	Generic.Files.LineLength.TooLong
Warning	tests/WithSampleReport.php:22	PHPCS.W.Generic.Files.LineLength.TooLong	Generic.Files.LineLength.TooLong
Warning	tests/WithSampleReport.php:26	PHPCS.W.Generic.Files.LineLength.TooLong	Generic.Files.LineLength.TooLong
Warning	tests/WithSampleReport.php:35	PHPCS.W.Generic.Files.LineLength.TooLong	Generic.Files.LineLength.TooLong
Warning	tests/WithSampleReport.php:36	PHPCS.W.Generic.Files.LineLength.TooLong	Generic.Files.LineLength.TooLong

Unit

Test Failures

Branch

arcpatch-D2503_1

Build Status

Buildable 3906
Build 4157: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	1 ms	Keruald\Reporting\Tests\Output\HTMLOutputTest Keruald\Reporting\Tests\Output\HTMLOutputTest::testRender Failed asserting that two strings are equal.
	1 ms	Keruald\Reporting\Tests\Output\MarkdownOutputTest Keruald\Reporting\Tests\Output\MarkdownOutputTest::testRender Failed asserting that two strings are equal.

Event Timeline

dereckson requested review of this revision.Feb 7 2022, 06:03

dereckson created this revision.

Harbormaster completed remote builds in B3897: Diff 6303.Feb 7 2022, 06:03

dereckson edited the summary of this revision. (Show Details)Feb 8 2022, 02:02

dereckson added a task: T1678: Health check and reporting library.

Seems to work fine, see D2505 for some fixes.

@DorianWinty was able to use this to create a report output.

Fixing tests per D2505

Harbormaster completed remote builds in B3901: Diff 6308.Feb 9 2022, 02:32

Fix spaces

Harbormaster completed remote builds in B3906: Diff 6314.Feb 9 2022, 17:26

Test failure is expected, implementation is D2505.

DorianWinty accepted this revision.Feb 9 2022, 17:37

This revision is now accepted and ready to land.Feb 9 2022, 17:37

This revision was landed with ongoing or failed builds.Feb 9 2022, 17:41

Closed by commit rKREPORTf6535b1db5d6: Test HTML and Markdown outputs (authored by dereckson). · Explain Why

This revision was automatically updated to reflect the committed changes.

dereckson added a commit: rKREPORTf6535b1db5d6: Test HTML and Markdown outputs.

dereckson mentioned this in D2505: Output report in HTML and Markdown.Feb 9 2022, 17:50

Revision Contents
Changeset List

Path

Size

src/

Output/

11 lines

MarkdownOutput.php

10 lines

31 lines

tests/

Output/

HTMLOutputTest.php

37 lines

MarkdownOutputTest.php

37 lines

WithSampleReport.php

58 lines

data/

43 lines

36 lines

Diff 6314

src/Output/HTMLOutput.php

Loading...

src/Output/MarkdownOutput.php

Loading...

src/Output/Output.php

Loading...

tests/Output/HTMLOutputTest.php

Loading...

tests/Output/MarkdownOutputTest.php

Loading...

tests/WithSampleReport.php

Loading...

tests/data/report.html

Loading...

tests/data/report.md

Loading...