Details

Reviewers

Maniphest Tasks

Commits

rOPS3674f0694509: Upgrade Sentry to 23.2.0

Summary

Volumes and environments are updated per getsentry/self-hosted repository.

Previously, services was defined separately for sentry web/cron/worker,
but the three was run form roles/paas-docker/containers/sentry.

Services are configured like for Snuba in D2881, each container uses
the same image, with a different launch command, especially as there
are now new ones.

Realm settings are refactored and contain service hosts information,
as we don't use links anymore. A realm will have a set of configuration
files.

The Sentry configuration is written in Python. This change provides
a configuration based on the getsentry/self-hosted one with:

services configured through the realm pillar
credentials directly fetched from Vault by Sentry itself

A Vault policy is provisioned for Sentry configuration.

Ref T1791

Test Plan

Deploy on docker-002

Diff Detail

Repository

rOPS Nasqueron Operations

Lint

Lint Errors

Severity	Location	Code	Message
Error	roles/paas-docker/containers/files/sentry/etc/sentry.conf.py:9	E501	flake8 E501
Error	roles/paas-docker/containers/files/sentry/etc/sentry.conf.py:10	E302	flake8 E302
Error	roles/paas-docker/containers/files/sentry/etc/sentry.conf.py:45	E305	flake8 E305
Error	roles/paas-docker/containers/files/sentry/etc/sentry.conf.py:79	F405	flake8 F405
Error	roles/paas-docker/containers/files/sentry/etc/sentry.conf.py:80	F405	flake8 F405
Error	roles/paas-docker/containers/files/sentry/etc/sentry.conf.py:90	F405	flake8 F405
Error	roles/paas-docker/containers/files/sentry/etc/sentry.conf.py:118	F405	flake8 F405
Error	roles/paas-docker/containers/files/sentry/etc/sentry.conf.py:149	F405	flake8 F405
Error	roles/paas-docker/containers/files/sentry/etc/sentry.conf.py:216	E501	flake8 E501
Error	roles/paas-docker/containers/files/sentry/etc/sentry.conf.py:257	F405	flake8 F405
Error	roles/paas-docker/containers/files/sentry/etc/sentry.conf.py:258	F405	flake8 F405
Error	roles/paas-docker/containers/files/sentry/etc/sentry.conf.py:264	F405	flake8 F405
Error	roles/paas-docker/containers/files/sentry/etc/sentry.conf.py:265	F405	flake8 F405
Error	roles/paas-docker/containers/files/sentry/etc/sentry.conf.py:296	F405	flake8 F405

Unit

No Test Coverage

Branch

sentry

Build Status

Buildable 4558
Build 4825: arc lint + arc unit

Event Timeline

dereckson requested review of this revision.Mar 13 2023, 18:22

dereckson created this revision.

Harbormaster completed remote builds in B4555: Diff 7354.Mar 13 2023, 18:22

dereckson retitled this revision from Update Sentry to 23.2.0 to Upgrade Sentry to 23.2.0.Mar 13 2023, 18:25

Network

Harbormaster completed remote builds in B4556: Diff 7355.Mar 13 2023, 18:59

docker-002

$ docker logs sentry_web
19:02:57 [WARNING] sentry.utils.geo: settings.GEOIP_PATH_MMDB not configured.
19:03:01 [INFO] sentry.plugins.github: apps-not-configured
/usr/local/lib/python3.8/site-packages/memcache.py:1303: SyntaxWarning: "is" with a literal. Did you mean "=="?
  if key is '':
/usr/local/lib/python3.8/site-packages/memcache.py:1304: SyntaxWarning: "is" with a literal. Did you mean "=="?
  if key_extra_len is 0:
!! Configuration error: ConfigurationError("sentry.tsdb service failed to call validate()\nmodule 'sentry.tsdb.redis' has no attribute 'RedisSnubaTSDB'")