Don't declare mutable variables as static
ClosedPublic
Actions

Authored by dereckson on May 15 2023, 16:37.

Tags

None

Referenced Files

	F7447198: D3095.diff
	Sat, Apr 26, 21:38

	Unknown Object (File)
	Fri, Apr 25, 17:40

	Unknown Object (File)
	Fri, Apr 25, 06:49

	Unknown Object (File)
	Thu, Apr 24, 08:20

	Unknown Object (File)
	Wed, Apr 23, 05:06

	Unknown Object (File)
	Tue, Apr 22, 21:08

	Unknown Object (File)
	Tue, Apr 22, 20:52

	Unknown Object (File)
	Tue, Apr 22, 15:40

View All Files

Subscribers

None

Details

Reviewers

dereckson

Maniphest Tasks

T1870: Can't end network registration on Freenode

Commits

rDARKBOT829d0e0bda75: Don't declare mutable variables as static

Summary

This is a follow-up for 3633321609ab.

Fixes T1870.

Test Plan

Tested with Odderon on Libera

Diff Detail

Repository

rDARKBOT Darkbot

Lint

Lint Passed

Unit

No Test Coverage

Branch

fix-static

Build Status

Buildable 4888
Build 5169: arc lint + arc unit

Event Timeline

dereckson requested review of this revision.May 15 2023, 16:37

dereckson created this revision.

Harbormaster completed remote builds in B4887: Diff 7900.May 15 2023, 16:37

Remove setup.ini SASL change, not in scope of this

Harbormaster completed remote builds in B4888: Diff 7901.May 15 2023, 16:40

Where we see why global variables are evil.

This revision is now accepted and ready to land.May 15 2023, 16:42

Closed by commit rDARKBOT829d0e0bda75: Don't declare mutable variables as static (authored by dereckson). · Explain WhyMay 15 2023, 16:42

This revision was automatically updated to reflect the committed changes.

dereckson added a commit: rDARKBOT829d0e0bda75: Don't declare mutable variables as static.

Revision Contents
Changeset List

Path

Size

source/

vars.h

7 lines

Diff 7901

View Options

Don't declare mutable variables as staticClosedPublicActions