Don't declare mutable variables as static
ClosedPublic
Actions

Authored by dereckson on May 15 2023, 16:37.

Tags

None

Referenced Files

	F3715444: D3095.id7901.diff
	Tue, Nov 5, 06:38

	F3715290: D3095.diff
	Tue, Nov 5, 04:32

	Unknown Object (File)
	Sun, Nov 3, 14:45

	Unknown Object (File)
	Sun, Nov 3, 04:47

	Unknown Object (File)
	Sat, Nov 2, 15:03

	Unknown Object (File)
	Sun, Oct 27, 03:04

	Unknown Object (File)
	Sun, Oct 27, 02:54

	Unknown Object (File)
	Sat, Oct 26, 15:39

View All Files

Subscribers

None

Details

Reviewers

dereckson

Maniphest Tasks

T1870: Can't end network registration on Freenode

Commits

rDARKBOT829d0e0bda75: Don't declare mutable variables as static

Summary

This is a follow-up for 3633321609ab.

Fixes T1870.

Test Plan

Tested with Odderon on Libera

Diff Detail

Repository

rDARKBOT Darkbot

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dereckson requested review of this revision.May 15 2023, 16:37

dereckson created this revision.

Harbormaster completed remote builds in B4887: Diff 7900.May 15 2023, 16:37

Remove setup.ini SASL change, not in scope of this

Harbormaster completed remote builds in B4888: Diff 7901.May 15 2023, 16:40

Where we see why global variables are evil.

This revision is now accepted and ready to land.May 15 2023, 16:42

Closed by commit rDARKBOT829d0e0bda75: Don't declare mutable variables as static (authored by dereckson). · Explain WhyMay 15 2023, 16:42

This revision was automatically updated to reflect the committed changes.

dereckson added a commit: rDARKBOT829d0e0bda75: Don't declare mutable variables as static.

Revision Contents
Changeset List

Path

Size

source/

vars.h

7 lines

Diff 7902

View Options

Don't declare mutable variables as staticClosedPublicActions