Make scripts more compliant with shellcheck linter.
Ref T1410
Details
Details
- Reviewers
dereckson - Maniphest Tasks
- T1410: Improve shell scripts to make them more solid (shellcheck)
- Commits
- rOPS63958ac275cd: Improve shell scripts robustness
Diff Detail
Diff Detail
- Repository
- rOPS Nasqueron Operations
- Lint
Lint Passed - Unit
No Test Coverage - Branch
- shellcheck (branched from main)
- Build Status
Buildable 5447 Build 5728: arc lint + arc unit
Event Timeline
Comment Actions
The true revision will be comming in next day, helping angelina to try arc diff and arcanist
Comment Actions
roles/core/certificates/files/letsencrypt-renewal.sh is sensible and so to test in different scenario, including a scenario where nginx returns 0 but raises a warning in stderr.
The other fixes look good to me.
| roles/core/certificates/files/letsencrypt-renewal.sh | ||
|---|---|---|
| 22 ↗ | (On Diff #8832) | We reproduced the test case documented in D372: $ [ "$nginx_return_code" -eq 0 ] && echo "${nginx_output}" | grep warn nginx: [warn] conflicting server name "forms.nasqueron.org" on 0.0.0.0:80, ignored nginx: [warn] conflicting server name "forms.nasqueron.org" on [::]:80, ignored nginx: [warn] conflicting server name "forms.nasqueron.org" on 0.0.0.0:443, ignored nginx: [warn] conflicting server name "forms.nasqueron.org" on [::]:443, ignored |