Paths

Table of Contentst

Differential D3690

Test DNS zone files
Needs ReviewPublic
Actions

Authored by dereckson on Thu, Sep 18, 16:38.

Tags

None

Referenced Files

	F11745767: D3690.id9546.diff
	Fri, Sep 19, 13:00

	F11745766: D3690.diff
	Fri, Sep 19, 13:00

	F11745763: D3690.id9547.diff
	Fri, Sep 19, 13:00

	F11744213: D3690.id9547.diff
	Fri, Sep 19, 06:02

	F11743539: D3690.id9546.diff
	Fri, Sep 19, 01:37

	F11743499: D3690.id9546.diff
	Fri, Sep 19, 01:17

	F11742929: D3690.id.diff
	Thu, Sep 18, 20:16

	F11742913: D3690.diff
	Thu, Sep 18, 19:59

View All 9 Files

Subscribers

None

Details

Reviewers

Maniphest Tasks

T1217: Host our DNS servers

Summary

Run sanity tests against roles/dns/knot/files/zones content:

do we have zone files defined in pillar?
can they be validated with kzonecheck?

Tests also validate the pillar files for content needed by zone files:

is dns_identity defined?

Test Plan

(cd _tests && make test-roles-dns)

Diff Detail

Repository

rOPS Nasqueron Operations

Lint

Lint Errors

Severity	Location	Code	Message
Error	_tests/roles/python/dns/test_dns_zones.py:29	E225	flake8 E225
Error	_tests/roles/python/dns/test_dns_zones.py:63	E225	flake8 E225
Error	_tests/roles/python/dns/test_dns_zones.py:77	E303	flake8 E303
Error	_tests/roles/python/dns/test_dns_zones.py:82	E302	flake8 E302
Error	_tests/roles/python/dns/test_dns_zones.py:101	E303	flake8 E303
Error	_tests/roles/python/dns/test_dns_zones.py:106	E302	flake8 E302
Error	_tests/roles/python/dns/test_dns_zones.py:145	E501	flake8 E501
Error	_tests/roles/python/dns/test_dns_zones.py:149	E501	flake8 E501
Error	_tests/roles/python/dns/test_dns_zones.py:158	E501	flake8 E501
Error	_tests/roles/python/dns/test_dns_zones.py:162	E303	flake8 E303
Error	_tests/roles/python/dns/test_dns_zones.py:167	E305	flake8 E305

Unit

No Test Coverage

Branch

tests-dns

Build Status

Buildable 5910
Build 6192: arc lint + arc unit

Event Timeline

dereckson requested review of this revision.Thu, Sep 18, 16:38

dereckson created this revision.

Harbormaster completed remote builds in B5910: Diff 9546.Thu, Sep 18, 16:38

black

Harbormaster completed remote builds in B5911: Diff 9547.Thu, Sep 18, 16:39

dereckson mentioned this in D3691: Use @ syntax for zone apex.Thu, Sep 18, 17:08

Revision Contents
Changeset List

Path

Size

_tests/

11 lines

roles/

python/

dns/

run_test_dns_zones.sh

27 lines

test_dns_zones.py

168 lines

roles/

dns/

knot/

2 lines

Diff 9546

_tests/Makefile

Loading...

_tests/roles/python/dns/run_test_dns_zones.sh

Loading...

_tests/roles/python/dns/test_dns_zones.py

Loading...

roles/dns/knot/config.sls

Loading...