Make Boolean immutable
ClosedPublic
Actions

Authored by dereckson on Jul 4 2023, 20:47.

Tags

None

Referenced Files

	F3752262: D3228.id8285.diff
	Sun, Nov 17, 17:42

	F3752222: D3228.id.diff
	Sun, Nov 17, 17:11

	F3752197: D3228.diff
	Sun, Nov 17, 16:52

	F3751816: D3228.id.diff
	Sun, Nov 17, 12:50

	F3751791: D3228.diff
	Sun, Nov 17, 12:36

	Unknown Object (File)
	Tue, Nov 12, 07:23

	Unknown Object (File)
	Tue, Nov 12, 06:48

	Unknown Object (File)
	Tue, Nov 12, 05:43

View All Files

Subscribers

None

Details

Reviewers

dereckson

Commits

rKOT98e7206acce8: Make Boolean immutable
rKERUALD14b3b96d96a6: Make Boolean immutable

Summary

To behave more like the scalar type, any operation
returns a NEW Boolean instance.

Test Plan

Unit tests from Keruald\OmniTools\Tests\Booleans\BooleanTest still pass

Diff Detail

Repository

rKERUALD Keruald libraries development repository

Lint

Lint Passed

Unit

Tests Passed

Branch

main

Build Status

Buildable 5091
Build 5372: arc lint + arc unit

Event Timeline

dereckson requested review of this revision.Jul 4 2023, 20:47

dereckson created this revision.

Harbormaster completed remote builds in B5091: Diff 8285.Jul 4 2023, 20:47

dereckson accepted this revision.Jul 4 2023, 20:47

dereckson edited the test plan for this revision. (Show Details)

This revision is now accepted and ready to land.Jul 4 2023, 20:48

Closed by commit rKERUALD14b3b96d96a6: Make Boolean immutable (authored by dereckson). · Explain WhyJul 4 2023, 20:48

This revision was automatically updated to reflect the committed changes.

dereckson added a commit: rKERUALD14b3b96d96a6: Make Boolean immutable.

dereckson added a commit: rKOT98e7206acce8: Make Boolean immutable.Jul 4 2023, 21:17

Revision Contents
Changeset List

Path

Size

omnitools/

src/

Booleans/

Boolean.php

36 lines

Diff 8285

View Options

omnitools/src/Booleans/Boolean.php

Make Boolean immutableClosedPublicActions