Page MenuHomeDevCentral

WIP: Test Keruald\GitHub\Events with JsonMapper
Needs ReviewPublic

Authored by aceppaluni on Nov 21 2024, 18:37.
Tags
None
Referenced Files
F11304908: D3598.diff
Fri, Aug 22, 11:08
F11304903: D3598.id.diff
Fri, Aug 22, 11:07
Unknown Object (File)
Thu, Aug 21, 06:51
Unknown Object (File)
Wed, Aug 20, 20:39
Unknown Object (File)
Wed, Aug 20, 08:08
Unknown Object (File)
Sun, Aug 17, 22:41
Unknown Object (File)
Sat, Aug 16, 23:21
Unknown Object (File)
Wed, Aug 13, 14:59
Subscribers
None

Details

Reviewers
dereckson
Summary

Testing Json PullRequest payload against mapping of PHP classes.

Diff Detail

Repository
rKERUALD Keruald libraries development repository
Lint
Lint Errors
SeverityLocationCodeMessage
Errorgithub/tests/Events/PullRequestTest.php:18PHPCS.E.PSR1.Classes.ClassDeclaration.MissingNamespacePSR1.Classes.ClassDeclaration.MissingNamespace
Errorgithub/tests/Events/PullRequestTest.php:27PHPCS.E.Generic.Files.LineLength.MaxExceededGeneric.Files.LineLength.MaxExceeded
Errorgithub/tests/Events/PullRequestTest.php:56PHPCS.E.Generic.Files.LineLength.MaxExceededGeneric.Files.LineLength.MaxExceeded
Errorgithub/tests/Events/PullRequestTest.php:62PHPCS.E.Generic.Files.LineLength.MaxExceededGeneric.Files.LineLength.MaxExceeded
Warninggithub/tests/Events/PullRequestTest.php:1PHPCS.W.PSR1.Files.SideEffects.FoundWithSymbolsPSR1.Files.SideEffects.FoundWithSymbols
Warninggithub/tests/Events/PullRequestTest.php:35PHPCS.W.Generic.Files.LineLength.TooLongGeneric.Files.LineLength.TooLong
Warninggithub/tests/Events/PullRequestTest.php:48PHPCS.W.Generic.Files.LineLength.TooLongGeneric.Files.LineLength.TooLong
Unit
Tests Passed
Branch
arcpatch-D3598
Build Status
Buildable 5776
Build 6058: arc lint + arc unit

Event Timeline

aceppaluni created this revision.

Adapt tests to adhere more to the payload content and our fixes to the Events classes (peer programming session).