Page MenuHomeDevCentral

WIP: Test Keruald\GitHub\Events with JsonMapper
Needs ReviewPublic

Authored by aceppaluni on Nov 21 2024, 18:37.
Tags
None
Referenced Files
F57567299: D3598.diff
Fri, Nov 20, 10:39
F57393842: D3598.diff
Wed, Nov 18, 11:37
F57236834: D3598.diff
Mon, Nov 16, 15:05
F57097652: D3598.diff
Sat, Nov 14, 13:54
F57023866: D3598.id9284.diff
Fri, Nov 13, 03:10
F56719701: D3598.id9284.diff
Sun, Nov 8, 14:45
F56655701: D3598.diff
Sun, Nov 8, 01:11
F56583114: D3598.diff
Sat, Nov 7, 10:28
Subscribers
None

Details

Reviewers
dereckson
Summary

Testing Json PullRequest payload against mapping of PHP classes.

Diff Detail

Repository
rKERUALD Keruald libraries development repository
Lint
Lint Errors
SeverityLocationCodeMessage
Errorgithub/src/Events/User.php:30PHPCS.E.Generic.Functions.OpeningFunctionBraceKernighanRitchie.BraceOnNewLineGeneric.Functions.OpeningFunctionBraceKernighanRitchie.BraceOnNewLine
Errorgithub/src/Events/User.php:37PHPCS.E.Generic.Functions.OpeningFunctionBraceKernighanRitchie.BraceOnNewLineGeneric.Functions.OpeningFunctionBraceKernighanRitchie.BraceOnNewLine
Errorgithub/src/Events/User.php:42PHPCS.E.Generic.Functions.OpeningFunctionBraceKernighanRitchie.BraceOnNewLineGeneric.Functions.OpeningFunctionBraceKernighanRitchie.BraceOnNewLine
Errorgithub/src/Events/User.php:47PHPCS.E.Generic.Functions.OpeningFunctionBraceKernighanRitchie.BraceOnNewLineGeneric.Functions.OpeningFunctionBraceKernighanRitchie.BraceOnNewLine
Errorgithub/tests/Events/jsonMapperTestPullRequest.php:17PHPCS.E.PSR1.Classes.ClassDeclaration.MissingNamespacePSR1.Classes.ClassDeclaration.MissingNamespace
Errorgithub/tests/Events/jsonMapperTestPullRequest.php:17PHPCS.E.Squiz.Classes.ValidClassName.NotCamelCapsSquiz.Classes.ValidClassName.NotCamelCaps
Errorgithub/tests/Events/jsonMapperTestPullRequest.php:26PHPCS.E.Generic.Files.LineLength.MaxExceededGeneric.Files.LineLength.MaxExceeded
Errorgithub/tests/Events/jsonMapperTestPullRequest.php:62PHPCS.E.Generic.Files.LineLength.MaxExceededGeneric.Files.LineLength.MaxExceeded
Warninggithub/tests/Events/jsonMapperTestPullRequest.php:1PHPCS.W.PSR1.Files.SideEffects.FoundWithSymbolsPSR1.Files.SideEffects.FoundWithSymbols
Warninggithub/tests/Events/jsonMapperTestPullRequest.php:28PHPCS.W.Generic.Files.LineLength.TooLongGeneric.Files.LineLength.TooLong
Warninggithub/tests/Events/jsonMapperTestPullRequest.php:30PHPCS.W.Generic.Files.LineLength.TooLongGeneric.Files.LineLength.TooLong
Warninggithub/tests/Events/jsonMapperTestPullRequest.php:46PHPCS.W.Generic.Files.LineLength.TooLongGeneric.Files.LineLength.TooLong
Warninggithub/tests/Events/jsonMapperTestPullRequest.php:53PHPCS.W.Generic.Files.LineLength.TooLongGeneric.Files.LineLength.TooLong
Warninggithub/tests/Events/jsonMapperTestPullRequest.php:66PHPCS.W.Generic.Files.LineLength.TooLongGeneric.Files.LineLength.TooLong
Unit
No Test Coverage
Branch
gitHubEvClasses--test
Build Status
Buildable 5727
Build 6009: arc lint + arc unit

Event Timeline

aceppaluni created this revision.

Adapt tests to adhere more to the payload content and our fixes to the Events classes (peer programming session).