Differential D3598

WIP: Test Keruald\GitHub\Events with JsonMapper
Needs ReviewPublic
Actions

Authored by aceppaluni on Nov 21 2024, 18:37.

Tags

None

Referenced Files

	F6554365: D3598.id.diff
	Mon, Mar 31, 11:47

	Unknown Object (File)
	Mon, Mar 31, 08:10

	Unknown Object (File)
	Mon, Mar 31, 05:17

	Unknown Object (File)
	Sun, Mar 30, 18:56

	Unknown Object (File)
	Sat, Mar 29, 02:48

	Unknown Object (File)
	Fri, Mar 28, 04:50

	Unknown Object (File)
	Wed, Mar 26, 10:07

	Unknown Object (File)
	Mon, Mar 24, 05:09

Subscribers

None

Details

Reviewers

Summary

Testing Json PullRequest payload against mapping of PHP classes.

Diff Detail

Repository

rKERUALD Keruald libraries development repository

Lint

Lint Errors

Severity	Location	Code	Message
Error	github/src/Events/User.php:30	PHPCS.E.Generic.Functions.OpeningFunctionBraceKernighanRitchie.BraceOnNewLine	Generic.Functions.OpeningFunctionBraceKernighanRitchie.BraceOnNewLine
Error	github/src/Events/User.php:37	PHPCS.E.Generic.Functions.OpeningFunctionBraceKernighanRitchie.BraceOnNewLine	Generic.Functions.OpeningFunctionBraceKernighanRitchie.BraceOnNewLine
Error	github/src/Events/User.php:42	PHPCS.E.Generic.Functions.OpeningFunctionBraceKernighanRitchie.BraceOnNewLine	Generic.Functions.OpeningFunctionBraceKernighanRitchie.BraceOnNewLine
Error	github/src/Events/User.php:47	PHPCS.E.Generic.Functions.OpeningFunctionBraceKernighanRitchie.BraceOnNewLine	Generic.Functions.OpeningFunctionBraceKernighanRitchie.BraceOnNewLine
Error	github/tests/Events/jsonMapperTestPullRequest.php:17	PHPCS.E.PSR1.Classes.ClassDeclaration.MissingNamespace	PSR1.Classes.ClassDeclaration.MissingNamespace
Error	github/tests/Events/jsonMapperTestPullRequest.php:17	PHPCS.E.Squiz.Classes.ValidClassName.NotCamelCaps	Squiz.Classes.ValidClassName.NotCamelCaps
Error	github/tests/Events/jsonMapperTestPullRequest.php:26	PHPCS.E.Generic.Files.LineLength.MaxExceeded	Generic.Files.LineLength.MaxExceeded
Error	github/tests/Events/jsonMapperTestPullRequest.php:62	PHPCS.E.Generic.Files.LineLength.MaxExceeded	Generic.Files.LineLength.MaxExceeded
Warning	github/tests/Events/jsonMapperTestPullRequest.php:1	PHPCS.W.PSR1.Files.SideEffects.FoundWithSymbols	PSR1.Files.SideEffects.FoundWithSymbols
Warning	github/tests/Events/jsonMapperTestPullRequest.php:28	PHPCS.W.Generic.Files.LineLength.TooLong	Generic.Files.LineLength.TooLong
Warning	github/tests/Events/jsonMapperTestPullRequest.php:30	PHPCS.W.Generic.Files.LineLength.TooLong	Generic.Files.LineLength.TooLong
Warning	github/tests/Events/jsonMapperTestPullRequest.php:46	PHPCS.W.Generic.Files.LineLength.TooLong	Generic.Files.LineLength.TooLong
Warning	github/tests/Events/jsonMapperTestPullRequest.php:53	PHPCS.W.Generic.Files.LineLength.TooLong	Generic.Files.LineLength.TooLong
Warning	github/tests/Events/jsonMapperTestPullRequest.php:66	PHPCS.W.Generic.Files.LineLength.TooLong	Generic.Files.LineLength.TooLong

Unit

No Test Coverage

Branch

gitHubEvClasses--test

Build Status

Buildable 5727
Build 6009: arc lint + arc unit

Event Timeline

aceppaluni requested review of this revision.Nov 21 2024, 18:37

aceppaluni created this revision.

Harbormaster completed remote builds in B5727: Diff 9284.Nov 21 2024, 18:37

Adapt tests to adhere more to the payload content and our fixes to the Events classes (peer programming session).

Harbormaster completed remote builds in B5776: Diff 9361.Dec 5 2024, 00:51

Revision Contents
Changeset List

Path

Size

3 lines

github/

src/

Events/

34 lines

tests/

Events/

jsonMapperTestPullRequest.php

69 lines

data/

pull-request-opened.json

520 lines

Diff 9284

composer.json

Loading...

github/src/Events/User.php

Loading...

github/tests/Events/jsonMapperTestPullRequest.php

Loading...

github/tests/data/pull-request-opened.json

Loading...