Page MenuHomeDevCentral

WIP: Test Keruald\GitHub\Events with JsonMapper
Needs ReviewPublic

Authored by aceppaluni on Nov 21 2024, 18:37.
Tags
None
Referenced Files
F57567299: D3598.diff
Fri, Nov 20, 10:39
F57393842: D3598.diff
Wed, Nov 18, 11:37
F57236834: D3598.diff
Mon, Nov 16, 15:05
F57097652: D3598.diff
Sat, Nov 14, 13:54
F57023866: D3598.id9284.diff
Fri, Nov 13, 03:10
F56719701: D3598.id9284.diff
Sun, Nov 8, 14:45
F56655701: D3598.diff
Sun, Nov 8, 01:11
F56583114: D3598.diff
Sat, Nov 7, 10:28
Subscribers
None

Details

Reviewers
dereckson
Summary

Testing Json PullRequest payload against mapping of PHP classes.

Diff Detail

Repository
rKERUALD Keruald libraries development repository
Lint
Lint Errors
SeverityLocationCodeMessage
Errorgithub/tests/Events/PullRequestTest.php:18PHPCS.E.PSR1.Classes.ClassDeclaration.MissingNamespacePSR1.Classes.ClassDeclaration.MissingNamespace
Errorgithub/tests/Events/PullRequestTest.php:27PHPCS.E.Generic.Files.LineLength.MaxExceededGeneric.Files.LineLength.MaxExceeded
Errorgithub/tests/Events/PullRequestTest.php:56PHPCS.E.Generic.Files.LineLength.MaxExceededGeneric.Files.LineLength.MaxExceeded
Errorgithub/tests/Events/PullRequestTest.php:62PHPCS.E.Generic.Files.LineLength.MaxExceededGeneric.Files.LineLength.MaxExceeded
Warninggithub/tests/Events/PullRequestTest.php:1PHPCS.W.PSR1.Files.SideEffects.FoundWithSymbolsPSR1.Files.SideEffects.FoundWithSymbols
Warninggithub/tests/Events/PullRequestTest.php:35PHPCS.W.Generic.Files.LineLength.TooLongGeneric.Files.LineLength.TooLong
Warninggithub/tests/Events/PullRequestTest.php:48PHPCS.W.Generic.Files.LineLength.TooLongGeneric.Files.LineLength.TooLong
Unit
Tests Passed
Branch
arcpatch-D3598
Build Status
Buildable 5776
Build 6058: arc lint + arc unit

Event Timeline

aceppaluni created this revision.

Adapt tests to adhere more to the payload content and our fixes to the Events classes (peer programming session).