Page MenuHomeDevCentral

Avoid importlib.machinery.SourceFileLoader load_module use
ClosedPublic

Authored by dereckson on Sep 17 2025, 16:42.
Tags
None
Referenced Files
F25149940: D3685.diff
Wed, Apr 1, 20:54
F25149073: D3685.id9537.diff
Wed, Apr 1, 19:10
Unknown Object (File)
Mon, Mar 30, 19:36
Unknown Object (File)
Mon, Mar 30, 10:23
Unknown Object (File)
Sun, Mar 29, 11:34
Unknown Object (File)
Sun, Mar 29, 10:22
Unknown Object (File)
Sat, Mar 28, 14:51
Unknown Object (File)
Sat, Mar 28, 13:06
Subscribers
None

Details

Summary

Currently, unit tests for Salt module and for scripts used the SourceFileLoader
class to manually load a specific script. The class load_module() method has
been deprecated for a while and won't be available in Python 3.12+.

Instead, we now use two strategies to import Python code:

  • treat _modules/ as a package folder by passing the path as PYTHONPATH
  • still use importlib for scripts, with compatible code

To import scripts directly with import can be a challenge, as roles like
"paas-docker" use dashes. The scripts filenames themselves contain dashes.

This fixes the following issue:
<frozen importlib._bootstrap>:283: DeprecationWarning: the load_module() method
is deprecated and slated for removal in Python 3.12; use exec_module() instead

Test Plan

On the T2123-improve-tests-suite branch to avoid distractions, make test
show every test pass without the deprecation warning.

Diff Detail

Repository
rOPS Nasqueron Operations
Lint
Lint Passed
Unit
No Test Coverage
Branch
T2123-improve-tests-suite
Build Status
Buildable 5903
Build 6185: arc lint + arc unit