Page MenuHomeDevCentral

Avoid importlib.machinery.SourceFileLoader load_module use
ClosedPublic

Authored by dereckson on Sep 17 2025, 16:42.
Tags
None
Referenced Files
F57235854: D3685.id9536.diff
Mon, Nov 16, 14:56
F57233351: D3685.id9724.diff
Mon, Nov 16, 14:02
F57123478: D3685.diff
Sun, Nov 15, 01:09
F57052950: D3685.diff
Fri, Nov 13, 19:44
F57016649: D3685.id9535.diff
Thu, Nov 12, 23:00
F57016025: D3685.id.diff
Thu, Nov 12, 22:31
F56987050: D3685.id9537.diff
Thu, Nov 12, 12:25
F56981359: D3685.id9536.diff
Thu, Nov 12, 09:09
Subscribers
None

Details

Summary

Currently, unit tests for Salt module and for scripts used the SourceFileLoader
class to manually load a specific script. The class load_module() method has
been deprecated for a while and won't be available in Python 3.12+.

Instead, we now use two strategies to import Python code:

  • treat _modules/ as a package folder by passing the path as PYTHONPATH
  • still use importlib for scripts, with compatible code

To import scripts directly with import can be a challenge, as roles like
"paas-docker" use dashes. The scripts filenames themselves contain dashes.

This fixes the following issue:
<frozen importlib._bootstrap>:283: DeprecationWarning: the load_module() method
is deprecated and slated for removal in Python 3.12; use exec_module() instead

Test Plan

On the T2123-improve-tests-suite branch to avoid distractions, make test
show every test pass without the deprecation warning.

Diff Detail

Repository
rOPS Nasqueron Operations
Lint
Lint Not Applicable
Unit
Tests Not Applicable