Propagate database events
ClosedPublic
Actions

Authored by dereckson on Sun, Oct 19, 10:06.

Details

Reviewers

Maniphest Tasks

Commits

rKDBad417e25084d: Propagate database events
rKOT17d6ef4f4010: Propagate database events
rKERUALD85207350c60e: Propagate database events

Summary

Obsidian offered the current refined code used in Keruald\Databases,
with an unported feature, connection and SQL error events.

This change migrates Obsidian Events static class in Keruald\OmniTools.
When that library is present, DatabaseEngine classes will fire events.

PSR-14: Event Dispatcher isn't currently implemented,
as we don't see any use case to justify a dependency
against Psr\EventDispatcher interfaces.

Fixes T1709.
Fixes Espace Win Bugzilla #21.

Test Plan

As part of T2145, switch to Keruald implementation in Obsdian Workspaces.

Diff Detail

Repository

rKERUALD Keruald libraries development repository

Lint

Lint Errors

Unit

Test Failures

Branch

database-events

Build Status

Buildable 6041
Build 6325: arc lint + arc unit

Unit TestsBroken
View All

	Time	Test
	0 ms	Keruald.Database.Tests.Engines.MySQLiEngineTest.testArrayShapeForFetchRow Keruald\Database\Tests\Engines\MySQLiEngineTest::testArrayShapeForFetchRow mysqli_sql_exception: No such file or directory
	0 ms	Keruald.Database.Tests.Engines.MySQLiEngineTest.testArrayShapeForFetchRowWithFetchModeBoth Keruald\Database\Tests\Engines\MySQLiEngineTest::testArrayShapeForFetchRowWithFetchModeBoth mysqli_sql_exception: No such file or directory
	0 ms	Keruald.Database.Tests.Engines.MySQLiEngineTest.testArrayShapeForFetchRowWithFetchModeEnum Keruald\Database\Tests\Engines\MySQLiEngineTest::testArrayShapeForFetchRowWithFetchModeEnum mysqli_sql_exception: No such file or directory
	0 ms	Keruald.Database.Tests.Engines.MySQLiEngineTest.testError Keruald\Database\Tests\Engines\MySQLiEngineTest::testError mysqli_sql_exception: No such file or directory
	0 ms	Keruald.Database.Tests.Engines.MySQLiEngineTest.testEscape Keruald\Database\Tests\Engines\MySQLiEngineTest::testEscape mysqli_sql_exception: No such file or directory
		View Full Test Results (27 Broken · 15 Passed)

Event Timeline

dereckson requested review of this revision.Sun, Oct 19, 10:06

dereckson created this revision.

Harbormaster completed remote builds in B6041: Diff 9768.Sun, Oct 19, 10:06

dereckson retitled this revision from Obsidian offered the current refined code used in Keruald\Databases, with an unported feature, connection and SQL error events. to Propagate database events.Sun, Oct 19, 10:08

dereckson edited the summary of this revision. (Show Details)

dereckson accepted this revision.Sun, Oct 19, 12:09

This revision is now accepted and ready to land.Sun, Oct 19, 12:09

This revision was landed with ongoing or failed builds.Sun, Oct 19, 12:09

Closed by commit rKERUALD85207350c60e: Propagate database events (authored by dereckson). · Explain Why

This revision was automatically updated to reflect the committed changes.

dereckson added a commit: rKERUALD85207350c60e: Propagate database events.

dereckson added a commit: rKOT17d6ef4f4010: Propagate database events.Sun, Oct 19, 12:14

dereckson added a commit: rKDBad417e25084d: Propagate database events.