Differential D3774

Switch events and databases classes to Keruald packages implementations
ClosedPublic
Actions

Authored by dereckson on Sun, Oct 19, 12:26.

Details

Reviewers

dereckson

Maniphest Tasks

T2145: Consolidate Obsidian classes with Keruald resources
T1709: Static events for database

Commits

rOBSIDIANdd8b7e76c36c: Switch events and databases class to Keruald packages implementations

Summary

This is a straightforward move as:

keruald/database was written from the Obsidian version
keruald/omnitools got the Events class as is

This is a follow-up of rKERUALD85207350c60e.

Ref T1709

Diff Detail

Repository

rOBSIDIAN Obsidian Workspaces

Lint

No Lint Coverage

Unit

Test Failures

Branch

main

Build Status

Buildable 6043
Build 6327: arc lint + arc unit

Unit TestsBroken
View All

	Time	Test
	0 ms	/Users/ssantoro/dev/nasqueron/obsidian/workspaces/tests/includes/database/DatabaseExceptionTest.php PHP Warning: require_once(/Users/ssantoro/dev/nasqueron/obsidian/workspaces/tests/includes/database/../../../src/includes/database/DatabaseException.php): Failed to open stream: No such file or directory in /Users/ssantoro/dev/nasqueron/obsidian/workspaces/tests/includes/database/DatabaseExceptionTest.php on line 20 Warning: require_once(/Users/ssantoro/dev/nasqueron/obsidian/workspaces/tests/includes/database/../../../src/includes/database/DatabaseException.php): Failed to open stream: No such file or directory in /Users/ssantoro/dev/nasqueron/obsidian/workspaces/tests/includes/database/DatabaseExceptionTest.php on line 20
	0 ms	/Users/ssantoro/dev/nasqueron/obsidian/workspaces/tests/includes/database/MySQLDatabaseTest.php

Event Timeline

dereckson requested review of this revision.Sun, Oct 19, 12:26

dereckson created this revision.

Harbormaster completed remote builds in B6043: Diff 9776.Sun, Oct 19, 12:26

Can be deleted now D3775 is merged.

Harbormaster completed remote builds in B6046: Diff 9781.Sun, Oct 19, 15:34

dereckson accepted this revision.Sun, Oct 19, 15:35

This revision is now accepted and ready to land.Sun, Oct 19, 15:35

Closed by commit rOBSIDIANdd8b7e76c36c: Switch events and databases class to Keruald packages implementations (authored by dereckson). · Explain WhySun, Oct 19, 15:35

This revision was automatically updated to reflect the committed changes.

dereckson added a commit: rOBSIDIANdd8b7e76c36c: Switch events and databases class to Keruald packages implementations.

dereckson retitled this revision from Switch events and databases class to Keruald packages implementations to Switch events and databases classes to Keruald packages implementations.Sun, Oct 19, 15:35

dereckson added a task: T2145: Consolidate Obsidian classes with Keruald resources.Sun, Oct 19, 21:45