Differential D804

Declare explicitely types
ClosedPublic
Actions

Authored by dereckson on Jan 7 2017, 06:07.

Tags

None

Referenced Files

	F34582403: D804.diff
	Thu, Jul 2, 05:48

	F34552831: D804.diff
	Thu, Jul 2, 00:38

	Unknown Object (File)
	Tue, Jun 30, 22:30

	Unknown Object (File)
	Wed, Jun 24, 06:54

	Unknown Object (File)
	Tue, Jun 23, 10:17

	Unknown Object (File)
	Tue, Jun 23, 08:50

	Unknown Object (File)
	Tue, Jun 23, 00:43

	Unknown Object (File)
	Mon, Jun 22, 19:07

Subscribers

None

Details

Reviewers

Commits

rNOTIF5be0d09ea7e0: Declare explicitely types

Summary

This is a follow-up for 5ea27e48acb2.

Test Plan

Run tests
Fixed type issue in keruald/github library when header is null

Diff Detail

Repository

rNOTIF Notifications center

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dereckson created this revision.Jan 7 2017, 06:07

dereckson accepted this revision.Jan 7 2017, 06:12

dereckson added a child revision: D805: Fix type issue in XHubSignature::parseSignature.

This revision is now accepted and ready to land.Jan 7 2017, 06:12

Bump keruald/github to 0.2.1 to get rKGHc0e14492852e.

Closed by commit rNOTIF5be0d09ea7e0: Declare explicitely types (authored by dereckson, committed by dereckson). · Explain WhyJan 7 2017, 06:18

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

app/

Http/

Controllers/

Gate/

DockerHubGateController.php

8 lines

GitHubGateController.php

16 lines

JenkinsGateController.php

4 lines

PhabricatorGateController.php

8 lines

2 lines

Diff 2043

app/Http/Controllers/Gate/DockerHubGateController.php

Loading...

app/Http/Controllers/Gate/GitHubGateController.php

Loading...

app/Http/Controllers/Gate/JenkinsGateController.php

Loading...

app/Http/Controllers/Gate/PhabricatorGateController.php

Loading...

composer.json

Loading...