Page MenuHomeDevCentral
Differential D804

Declare explicitely types
ClosedPublic
Actions

Authored by dereckson on Jan 7 2017, 06:07.
Tags
None
Referenced Files
F50917707: D804.id2042.diff
Mon, Sep 21, 19:43
F50890941: D804.id2042.diff
Mon, Sep 21, 14:53
F50881933: D804.id.diff
Mon, Sep 21, 13:19
F50881412: D804.id2043.diff
Mon, Sep 21, 13:10
F50880502: D804.id.diff
Mon, Sep 21, 12:54
F50878822: D804.id2043.diff
Mon, Sep 21, 12:29
F50874279: D804.id2038.diff
Mon, Sep 21, 11:38
F50872634: D804.id2038.diff
Mon, Sep 21, 11:24
View All Files
Subscribers
None

Details

Reviewers
dereckson
Commits
rNOTIF5be0d09ea7e0: Declare explicitely types
Summary

This is a follow-up for 5ea27e48acb2.

Test Plan
  • Run tests
  • Fixed type issue in keruald/github library when header is null

Diff Detail

Repository
rNOTIF Notifications center
Lint
Lint Passed
Unit
No Test Coverage
Branch
more-strict-types (branched from master)
Build Status
Buildable 1236
Build 1484: arc lint + arc unit

Event Timeline

dereckson created this revision.Jan 7 2017, 06:07
dereckson accepted this revision.Jan 7 2017, 06:12
dereckson added a child revision: D805: Fix type issue in XHubSignature::parseSignature.
This revision is now accepted and ready to land.Jan 7 2017, 06:12
dereckson updated this revision to Diff 2042.Jan 7 2017, 06:17

Bump keruald/github to 0.2.1 to get rKGHc0e14492852e.

Closed by commit rNOTIF5be0d09ea7e0: Declare explicitely types (authored by dereckson, committed by dereckson). · Explain WhyJan 7 2017, 06:18
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 2042

View Options

app/Http/Controllers/Gate/DockerHubGateController.php

Loading...
View Options

app/Http/Controllers/Gate/GitHubGateController.php

Loading...
View Options

app/Http/Controllers/Gate/JenkinsGateController.php

Loading...
View Options

app/Http/Controllers/Gate/PhabricatorGateController.php

Loading...
View Options

composer.json

Loading...
Nasqueron DevCentral · If it had been much bigger the moon would have had a core of ice. · Powered by Phabricator