Maniphest T1064

Handle TypeError exceptions in ProjectsMapTest
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	dereckson
	Dec 18 2016, 19:58

Tags

Referenced Files

None

Subscribers

Description

A rapid phpunit run on PHP 7 gives new throwables:

Nasqueron\Notifications\Tests\Phabricator\ProjectsMapTest::testFetchFromAPIWithoutReply — Failed asserting that exception of type "TypeError" matches expected exception "Exception".
Nasqueron\Notifications\Tests\Phabricator\ProjectsMapTest::testFetchFromAPIInvalidReply — Failed asserting that exception of type "TypeError" matches expected exception "Exception".

Revisions and Commits

rNOTIF Notifications center
	D753	rNOTIF22c6596059eb Upgrade code to PHP 7.1

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		None	T1062 Upgrade notifications center code base to PHP 7
		Resolved		dereckson	T1064 Handle TypeError exceptions in ProjectsMapTest

Event Timeline

dereckson created this task.Dec 18 2016, 19:58

dereckson moved this task from Backlog to In progress on the Notifications center (No, this is not a magic elixir, this is a fir distillate.) board.

dereckson added a revision: D753: Upgrade code to PHP 7.1.Dec 19 2016, 00:37

So this was a type bug in the test: we returned a Mockery\CompositeExpectation instance, and not a relevant APIClient class.

dereckson moved this task from In progress to Needs Review / Blocked / Waiting on the Notifications center (No, this is not a magic elixir, this is a fir distillate.) board.Dec 19 2016, 01:01

dereckson closed this task as Resolved by committing rNOTIF22c6596059eb: Upgrade code to PHP 7.1.Dec 25 2016, 18:54

dereckson added a commit: rNOTIF22c6596059eb: Upgrade code to PHP 7.1.