Allow Jenkins to run tests on PHP 7
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	dereckson
	Dec 20 2016, 15:16

Description

rNOTIF needs this

Pending issues

upstream https://github.com/theseer/phpdox/issues/300 - Nullable type support in phpdox
pdepend doesn't handle ... or the nullable operator

Revisions and Commits

rDJENKINSAGENTS Docker images for Jenkins agents
	D766	rDJENKINSAGENTS21ed1235dcc6 Use PHP 7.1 Docker image

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		None	T1068 Allow Jenkins to run tests on PHP 7
		Resolved		dereckson	T1072 Upgrade docker/php-cli to PHP 7

Event Timeline

dereckson created this task.Dec 20 2016, 15:16

dereckson moved this task from Backlog to Docker on the PHP 7 deployment board.Dec 22 2016, 19:12

We've now a Docker image with nginx and PHP 7:

Dwellers

$ docker run -dt -v /tmp/phpinfo/:/var/wwwroot/default -p 8080:80 nasqueron/nginx-php7-fpm

Next step is to create the CLI version.

A question was if a new 7.1 image was valuable or it would be better to only focus on one image.

For that, we used Arcanist under PHP 7 for a while, and that doesn't seem to cause issue. If issues would appear in the future it could use a :5.6.x tagged version.

We're going to upgrade the image, ensure all the tools run on PHP 7 and fix or supersede them.

dereckson mentioned this in T1072: Upgrade docker/php-cli to PHP 7.Dec 24 2016, 13:20

dereckson added a subtask: T1072: Upgrade docker/php-cli to PHP 7.

dereckson moved this task from Next to In progress on the Notifications center (No, this is not a magic elixir, this is a fir distillate.) board.Dec 25 2016, 01:43

An ant build of rNOTIF gives rather good results in 9 minutes and 53 seconds, time mainly used by Composer. Tests with XDebug run in 2.25 minutes. The Ant build quits as successful.

Issues

pdepend 2.3.2 doesn't like modern PHP tokens (PHP 5 argument expansion or PHP 7.1 nullable)
phpdox: Object of class PhpParser\Node\NullableType could not be converted to string

PDepend

[pdepend] The following errors occurred:
[pdepend] Unexpected token: ..., line: 177, col: 27, file: /home/app/notifications-center/app/Console/Commands/NotificationsPayload.php.
[pdepend] Unexpected token: ?, line: 146, col: 61, file: /home/app/notifications-center/app/Phabricator/ProjectsMap.php.

phpdox

  [phpdox] [25.12.2016 - 02:46:14] The following file(s) had errors during processing and were excluded:
  [phpdox] [25.12.2016 - 02:46:14]  - /home/app/notifications-center/app/Phabricator/ProjectsMap.php (Object of class PhpParser\Node\NullableType could not be
converted to string)
  [phpdox] [25.12.2016 - 02:46:14] Saving results to directory '/home/app/notifications-center/build/phpdox'
  [phpdox] [25.12.2016 - 02:46:16] Resolving inheritance

dereckson updated the task description. (Show Details)Dec 25 2016, 03:15

dereckson added a revision: D766: Use PHP 7.1 Docker image.Dec 25 2016, 03:47

dereckson mentioned this in D766: Use PHP 7.1 Docker image.Dec 25 2016, 11:49

dereckson closed this task as Resolved by committing rDJENKINSAGENTS21ed1235dcc6: Use PHP 7.1 Docker image.Dec 25 2016, 12:02

dereckson added a commit: rDJENKINSAGENTS21ed1235dcc6: Use PHP 7.1 Docker image.

dereckson closed subtask T1072: Upgrade docker/php-cli to PHP 7 as Resolved.Dec 25 2016, 12:10