Maniphest T2035

Tidy up Keruald\GitHub package repository
Open, NormalPublic
Actions

Assigned To

Authored By

	dereckson
	Sep 30 2024, 22:49

Description

Notifications Center (rNOTIF) uses the package Keruald\GitHub hosted in repository rKGH to verify X-Hub-Signature from GitHub payloads.

In T595, we would like to provide classes to map those events, for example in Keruald\GitHub\Events namespace.

To prepare the repository for that work, the following tasks would be useful:

Host repository on Phabricator (it's still on GitHub)
switch to main branch
move source code to src/ folder, adapt PSR-4 loader configuration in composer.json
merge the repository into rKERUALD monorepo
document it at https://agora.nasqueron.org/Keruald
bump requirement from PHP 5.6+ to PHP 8.1+ and improve typing accordingly - done for tests, still to do for src

Revisions and Commits

rKERUALD Keruald libraries development repository
	D3528	rKERUALDe680c74ed37c Update tests to PHPUnit 11
	D3527	rKERUALD5a5f82940bfb Define src/ as source code root
rKGH Keruald GitHub
	D3528	rKGHe680c74ed37c Update tests to PHPUnit 11
	D3527	rKGH5a5f82940bfb Define src/ as source code root

Related Objects
Search...

Status	Assigned	Task
Resolved	dereckson	T594 Accept GitHub Webhooks API payloads
Open	None	T1076 Map payload to classes
Open	aceppaluni	T595 GitHub event types classes
Open	dereckson	T2035 Tidy up Keruald\GitHub package repository

Event Timeline

I'm planning to work on this after WindRiver migration, that should be quick, we've only one class and a more comprehensive test folder.

dereckson moved this task from Backlog to Debt on the Keruald board.Sep 30 2024, 22:51

dereckson moved this task from Backlog to Next on the User-Dereckson board.

dereckson moved this task from Backlog to Debt on the Notifications center board.

dereckson updated the task description. (Show Details)Oct 8 2024, 00:49

Repository now uses main branch and is hosted here, with GitHub as mirror.

Devcentral configuration

The repository still refered to staging SSHD on port 7022. I've removed the configuration from rKGH.

$ arc diff HEAD^
[…]
 PUSH STAGING  Pushing changes to staging area...
ssh: connect to host devcentral.nasqueron.org port 7022: Connection refused
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.
 STAGING FAILED  Unable to push changes to the staging area.
[…]