Page MenuHomeDevCentral
Create Task
Maniphest T2035

Tidy up Keruald\GitHub package repository
Open, NormalPublic
Actions

Description

Notifications Center (rNOTIF) uses the package Keruald\GitHub hosted in repository rKGH to verify X-Hub-Signature from GitHub payloads.

In T595, we would like to provide classes to map those events, for example in Keruald\GitHub\Events namespace.

To prepare the repository for that work, the following tasks would be useful:

  • Host repository on Phabricator (it's still on GitHub)
  • switch to main branch
  • move source code to src/ folder, adapt PSR-4 loader configuration in composer.json
  • merge the repository into rKERUALD monorepo
  • document it at https://agora.nasqueron.org/Keruald
  • bump requirement from PHP 5.6+ to PHP 8.1+ and improve typing accordingly - done for tests, still to do for src

Revisions and Commits

rKGH Keruald GitHub
Needs ReviewD3528 Update tests to PHPUnit 11
Needs ReviewD3527 Define src/ as source code root

Related Objects
Search...

Event Timeline

dereckson triaged this task as Normal priority.Mon, Sep 30, 22:49
dereckson created this task.
dereckson added projects: Keruald, User-Dereckson.

I'm planning to work on this after WindRiver migration, that should be quick, we've only one class and a more comprehensive test folder.

dereckson moved this task from Backlog to Debt on the Keruald board.Mon, Sep 30, 22:51
dereckson moved this task from Backlog to Next on the User-Dereckson board.
dereckson moved this task from Backlog to Debt on the Notifications center board.
dereckson updated the task description. (Show Details)Tue, Oct 8, 00:49
dereckson moved this task from Next to In progress on the User-Dereckson board.Wed, Oct 16, 22:28
dereckson updated the task description. (Show Details)

Repository now uses main branch and is hosted here, with GitHub as mirror.

dereckson added a comment.Wed, Oct 16, 22:50

Devcentral configuration

The repository still refered to staging SSHD on port 7022. I've removed the configuration from rKGH.

$ arc diff HEAD^
[…]
 PUSH STAGING  Pushing changes to staging area...
ssh: connect to host devcentral.nasqueron.org port 7022: Connection refused
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.
 STAGING FAILED  Unable to push changes to the staging area.
[…]
dereckson added a revision: D3527: Define src/ as source code root.Wed, Oct 16, 22:50
dereckson updated the task description. (Show Details)Wed, Oct 16, 23:12
dereckson added a revision: D3528: Update tests to PHPUnit 11.Wed, Oct 16, 23:20
Nasqueron DevCentral · If it had been much bigger the moon would have had a core of ice. · Powered by Phabricator