Page MenuHomeDevCentral
Differential D4077

Refactor URL encode/decode
Needs ReviewPublic
Actions

Authored by dereckson on Apr 18 2026, 13:00.
Tags
None
Referenced Files
F49041893: D4077.id11039.diff
Thu, Sep 10, 02:42
F49007873: D4077.id10640.diff
Wed, Sep 9, 22:16
F48999108: D4077.diff
Wed, Sep 9, 21:10
Unknown Object (File)
Mon, Sep 7, 22:00
Unknown Object (File)
Mon, Sep 7, 18:14
Unknown Object (File)
Mon, Sep 7, 03:14
Unknown Object (File)
Sun, Sep 6, 04:20
Unknown Object (File)
Sun, Sep 6, 02:06
View All Files
Subscribers
Duranzed

Details

Reviewers
Duranzed

Diff Detail

Repository
rKERUALD Keruald libraries development repository
Lint
Lint Errors
SeverityLocationCodeMessage
Erroromnitools/src/HTTP/QueryEncoding.php:9PHPCS.E.Generic.Classes.OpeningBraceSameLine.BraceOnNewLineGeneric.Classes.OpeningBraceSameLine.BraceOnNewLine
Erroromnitools/src/HTTP/URL.php:163PHPCS.E.Generic.Formatting.SpaceAfterCast.TooMuchSpaceGeneric.Formatting.SpaceAfterCast.TooMuchSpace
Unit
Tests Passed
Branch
follow-up-for-doc-iii
Build Status
Buildable 6866
Build 7154: arc lint + arc unit

Event Timeline

dereckson requested review of this revision.Apr 18 2026, 13:00
dereckson created this revision.
Harbormaster completed remote builds in B6630: Diff 10640.Apr 18 2026, 13:00
dereckson added a parent revision: D2810: Generate and enrich documentation.Apr 18 2026, 13:00
Duranzed requested changes to this revision.May 18 2026, 23:15
Duranzed added a subscriber: Duranzed.

Harbormaster reports unit test failures on omnitools/tests/HTTP/URLTest.php, also the exception message changed in beautifyQuery() from "Unexpected encoding value" to "Unexpected value", while normalizeQuery() keeps "Unexpected encoding value".

This revision now requires changes to proceed.May 18 2026, 23:15
dereckson updated this revision to Diff 10763.Jun 7 2026, 09:48

Restore full exception message

Harbormaster completed remote builds in B6712: Diff 10763.Jun 7 2026, 09:48
dereckson updated this revision to Diff 11038.Mon, Sep 7, 22:40

Move constantes to a backed enum, so we can get autocomplete from IDEs
and exhaustive matching.

_toString() -> (string) cast

Harbormaster completed remote builds in B6866: Diff 11038.Mon, Sep 7, 22:40
dereckson updated this revision to Diff 11039.Mon, Sep 7, 22:42

phpcs

Harbormaster completed remote builds in B6867: Diff 11039.Mon, Sep 7, 22:42
dereckson added a comment.Mon, Sep 7, 22:54

Exception can be removed using an PHP 8.1 enum instead of in-class constants.

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
omnitools/
src/
HTTP/
26 lines--
83 lines98%
Loading...

Diff 11038

View Options

omnitools/src/HTTP/QueryEncoding.php

Loading...
View Options

omnitools/src/HTTP/URL.php

Loading...
Nasqueron DevCentral · If it had been much bigger the moon would have had a core of ice. · Powered by Phabricator