Differential D4077

Refactor URL encode/decode
Needs ReviewPublic
Actions

Authored by dereckson on Apr 18 2026, 13:00.

Details

Reviewers

Duranzed

Diff Detail

Repository

rKERUALD Keruald libraries development repository

Lint

Lint Passed

Unit

Tests Passed

Branch

follow-up-for-doc-iii

Build Status

Buildable 6867
Build 7155: arc lint + arc unit

Event Timeline

dereckson requested review of this revision.Apr 18 2026, 13:00

dereckson created this revision.

Harbormaster completed remote builds in B6630: Diff 10640.Apr 18 2026, 13:00

dereckson added a parent revision: D2810: Generate and enrich documentation.Apr 18 2026, 13:00

Harbormaster reports unit test failures on omnitools/tests/HTTP/URLTest.php, also the exception message changed in beautifyQuery() from "Unexpected encoding value" to "Unexpected value", while normalizeQuery() keeps "Unexpected encoding value".

This revision now requires changes to proceed.May 18 2026, 23:15

Restore full exception message

Harbormaster completed remote builds in B6712: Diff 10763.Jun 7 2026, 09:48

Move constantes to a backed enum, so we can get autocomplete from IDEs
and exhaustive matching.

_toString() -> (string) cast

Harbormaster completed remote builds in B6866: Diff 11038.Mon, Sep 7, 22:40

phpcs

Harbormaster completed remote builds in B6867: Diff 11039.Mon, Sep 7, 22:42

Exception can be removed using an PHP 8.1 enum instead of in-class constants.

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

omnitools/

src/

HTTP/

QueryEncoding.php

25 lines

URL.php

83 lines

98%

Diff 11039

View Options

omnitools/src/HTTP/QueryEncoding.php