Page MenuHomeDevCentral
Differential D753

Upgrade code to PHP 7.1
ClosedPublic
Actions

Authored by dereckson on Dec 19 2016, 00:35.
Tags
Referenced Files
F4040930: D753.id1891.diff
Wed, Jan 22, 06:19
F4037088: D753.id1890.diff
Tue, Jan 21, 22:42
Unknown Object (File)
Thu, Jan 16, 06:29
Unknown Object (File)
Wed, Jan 15, 03:01
Unknown Object (File)
Mon, Jan 13, 03:31
Unknown Object (File)
Sun, Jan 12, 15:26
Unknown Object (File)
Sun, Jan 12, 15:24
Unknown Object (File)
Sun, Jan 12, 15:23
View All Files
Subscribers
alken-orin

Details

Reviewers
dereckson
Maniphest Tasks
T1062: Upgrade notifications center code base to PHP 7
T1064: Handle TypeError exceptions in ProjectsMapTest
Commits
rNOTIF22c6596059eb: Upgrade code to PHP 7.1
Summary

The current code works virtually without issue on PHP 7,
as it was prepared with PHP 7 in mind as target version.

In order to work nicely with PHP 7.1:

  • use nullable parameters type
  • fix ProjectsMapTest tests mock type, using an anonymous class

We also bump the version in Composer.

References:

Fixes T1064. Ref T1062.

Test Plan

All unit tests pass.

Diff Detail

Repository
rNOTIF Notifications center
Lint
Lint Passed
Unit
Tests Passed
Branch
php7 (branched from master)

Event Timeline

dereckson created this revision.Dec 19 2016, 00:35
dereckson edited the summary of this revision. (Show Details)Dec 19 2016, 00:37
dereckson edited the test plan for this revision. (Show Details)
dereckson added a reviewer: dereckson.
dereckson added a project: PHP 7 deployment.
dereckson added tasks: T1064: Handle TypeError exceptions in ProjectsMapTest, T1062: Upgrade notifications center code base to PHP 7.
dereckson added inline comments.Dec 19 2016, 00:39
tests/Phabricator/ProjectsMapTest.php
191

?

alken-orin added a subscriber: alken-orin.Dec 19 2016, 00:42

Build has FAILED

Link to build: https://ci.nasqueron.org/job/test-notifications-phab/219/
See console output for more information: https://ci.nasqueron.org/job/test-notifications-phab/219/console

dereckson updated this revision to Diff 1891.Dec 19 2016, 00:46
dereckson edited edge metadata.

Whitespace issue, use APIClient

alken-orin added a comment.Dec 19 2016, 00:49

Build has FAILED

Link to build: https://ci.nasqueron.org/job/test-notifications-phab/220/
See console output for more information: https://ci.nasqueron.org/job/test-notifications-phab/220/console

dereckson marked an inline comment as done.Dec 19 2016, 01:00
dereckson updated this revision to Diff 1914.Dec 20 2016, 11:33

Rebased against master. Jenkins will still try this on a PHP 5.2 container (see T625), so tests are expected to fail.

alken-orin added a comment.Dec 20 2016, 12:03

Build has FAILED

Link to build: https://ci.nasqueron.org/job/test-notifications-phab/223/
See console output for more information: https://ci.nasqueron.org/job/test-notifications-phab/223/console

alken-orin added a comment.Dec 25 2016, 12:19

Build is green https://ci.nasqueron.org/job/test-notifications-phab/224/ for more details.

dereckson accepted this revision.Dec 25 2016, 16:40
dereckson edited edge metadata.
This revision is now accepted and ready to land.Dec 25 2016, 16:40
dereckson edited the summary of this revision. (Show Details)Dec 25 2016, 17:48
Closed by commit rNOTIF22c6596059eb: Upgrade code to PHP 7.1 (authored by dereckson, committed by dereckson). · Explain WhyDec 25 2016, 18:54
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
app/
Phabricator/
6 lines
2 lines
tests/
Phabricator/
19 lines

Diff 1891

View Options

app/Phabricator/ProjectsMap.php

Loading...
View Options

composer.json

Loading...
View Options

tests/Phabricator/ProjectsMapTest.php

Loading...
Nasqueron DevCentral · If it had been much bigger the moon would have had a core of ice. · Powered by Phabricator