Page MenuHomeDevCentral

Upgrade code to PHP 7.1
ClosedPublic

Authored by dereckson on Dec 19 2016, 00:35.
Referenced Files
F3715373: D753.diff
Tue, Nov 5, 05:21
Unknown Object (File)
Mon, Oct 28, 09:37
Unknown Object (File)
Mon, Oct 28, 07:26
Unknown Object (File)
Sat, Oct 26, 19:28
Unknown Object (File)
Sat, Oct 26, 14:29
Unknown Object (File)
Sat, Oct 19, 13:59
Unknown Object (File)
Mon, Oct 7, 06:24
Unknown Object (File)
Oct 4 2024, 03:14
Subscribers

Details

Summary

The current code works virtually without issue on PHP 7,
as it was prepared with PHP 7 in mind as target version.

In order to work nicely with PHP 7.1:

  • use nullable parameters type
  • fix ProjectsMapTest tests mock type, using an anonymous class

We also bump the version in Composer.

References:

Fixes T1064. Ref T1062.

Test Plan

All unit tests pass.

Diff Detail

Repository
rNOTIF Notifications center
Lint
Lint Passed
Unit
Tests Passed
Branch
php7 (branched from master)

Event Timeline

tests/Phabricator/ProjectsMapTest.php
191

?

dereckson edited edge metadata.

Whitespace issue, use APIClient

Rebased against master. Jenkins will still try this on a PHP 5.2 container (see T625), so tests are expected to fail.

dereckson edited edge metadata.
This revision is now accepted and ready to land.Dec 25 2016, 16:40
This revision was automatically updated to reflect the committed changes.