Page MenuHomeDevCentral

WIP: Test Keruald\GitHub\Events with JsonMapper
Needs ReviewPublic

Authored by aceppaluni on Nov 21 2024, 18:37.
Tags
None
Referenced Files
F24490656: D3598.diff
Mon, Feb 23, 07:24
F24489652: D3598.diff
Mon, Feb 23, 05:51
F24485770: D3598.id9361.diff
Mon, Feb 23, 00:23
F24485727: D3598.id9361.diff
Mon, Feb 23, 00:18
Unknown Object (File)
Mon, Feb 16, 23:39
Unknown Object (File)
Mon, Feb 16, 23:26
Unknown Object (File)
Mon, Feb 16, 15:10
Unknown Object (File)
Mon, Feb 16, 15:10
Subscribers
None

Details

Reviewers
dereckson
Summary

Testing Json PullRequest payload against mapping of PHP classes.

Diff Detail

Repository
rKERUALD Keruald libraries development repository
Lint
Lint Errors
SeverityLocationCodeMessage
Errorgithub/src/Events/User.php:30PHPCS.E.Generic.Functions.OpeningFunctionBraceKernighanRitchie.BraceOnNewLineGeneric.Functions.OpeningFunctionBraceKernighanRitchie.BraceOnNewLine
Errorgithub/src/Events/User.php:37PHPCS.E.Generic.Functions.OpeningFunctionBraceKernighanRitchie.BraceOnNewLineGeneric.Functions.OpeningFunctionBraceKernighanRitchie.BraceOnNewLine
Errorgithub/src/Events/User.php:42PHPCS.E.Generic.Functions.OpeningFunctionBraceKernighanRitchie.BraceOnNewLineGeneric.Functions.OpeningFunctionBraceKernighanRitchie.BraceOnNewLine
Errorgithub/src/Events/User.php:47PHPCS.E.Generic.Functions.OpeningFunctionBraceKernighanRitchie.BraceOnNewLineGeneric.Functions.OpeningFunctionBraceKernighanRitchie.BraceOnNewLine
Errorgithub/tests/Events/jsonMapperTestPullRequest.php:17PHPCS.E.PSR1.Classes.ClassDeclaration.MissingNamespacePSR1.Classes.ClassDeclaration.MissingNamespace
Errorgithub/tests/Events/jsonMapperTestPullRequest.php:17PHPCS.E.Squiz.Classes.ValidClassName.NotCamelCapsSquiz.Classes.ValidClassName.NotCamelCaps
Errorgithub/tests/Events/jsonMapperTestPullRequest.php:26PHPCS.E.Generic.Files.LineLength.MaxExceededGeneric.Files.LineLength.MaxExceeded
Errorgithub/tests/Events/jsonMapperTestPullRequest.php:62PHPCS.E.Generic.Files.LineLength.MaxExceededGeneric.Files.LineLength.MaxExceeded
Warninggithub/tests/Events/jsonMapperTestPullRequest.php:1PHPCS.W.PSR1.Files.SideEffects.FoundWithSymbolsPSR1.Files.SideEffects.FoundWithSymbols
Warninggithub/tests/Events/jsonMapperTestPullRequest.php:28PHPCS.W.Generic.Files.LineLength.TooLongGeneric.Files.LineLength.TooLong
Warninggithub/tests/Events/jsonMapperTestPullRequest.php:30PHPCS.W.Generic.Files.LineLength.TooLongGeneric.Files.LineLength.TooLong
Warninggithub/tests/Events/jsonMapperTestPullRequest.php:46PHPCS.W.Generic.Files.LineLength.TooLongGeneric.Files.LineLength.TooLong
Warninggithub/tests/Events/jsonMapperTestPullRequest.php:53PHPCS.W.Generic.Files.LineLength.TooLongGeneric.Files.LineLength.TooLong
Warninggithub/tests/Events/jsonMapperTestPullRequest.php:66PHPCS.W.Generic.Files.LineLength.TooLongGeneric.Files.LineLength.TooLong
Unit
No Test Coverage
Branch
gitHubEvClasses--test
Build Status
Buildable 5727
Build 6009: arc lint + arc unit

Event Timeline

aceppaluni created this revision.

Adapt tests to adhere more to the payload content and our fixes to the Events classes (peer programming session).