Differential D3598

WIP: Test Keruald\GitHub\Events with JsonMapper
Needs ReviewPublic
Actions

Authored by aceppaluni on Thu, Nov 21, 18:37.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Dec 13, 09:51

	Unknown Object (File)
	Thu, Dec 12, 08:16

	Unknown Object (File)
	Tue, Dec 10, 17:44

	Unknown Object (File)
	Tue, Dec 10, 10:35

	Unknown Object (File)
	Tue, Dec 10, 00:26

	Unknown Object (File)
	Sun, Dec 8, 11:40

	Unknown Object (File)
	Wed, Dec 4, 09:12

	Unknown Object (File)
	Tue, Dec 3, 12:55

View All 23 Files

Subscribers

None

Details

Reviewers

Summary

Testing Json PullRequest payload against mapping of PHP classes.

Diff Detail

Repository

rKERUALD Keruald libraries development repository

Lint

Lint Errors

Severity	Location	Code	Message
Error	github/tests/Events/PullRequestTest.php:18	PHPCS.E.PSR1.Classes.ClassDeclaration.MissingNamespace	PSR1.Classes.ClassDeclaration.MissingNamespace
Error	github/tests/Events/PullRequestTest.php:27	PHPCS.E.Generic.Files.LineLength.MaxExceeded	Generic.Files.LineLength.MaxExceeded
Error	github/tests/Events/PullRequestTest.php:56	PHPCS.E.Generic.Files.LineLength.MaxExceeded	Generic.Files.LineLength.MaxExceeded
Error	github/tests/Events/PullRequestTest.php:62	PHPCS.E.Generic.Files.LineLength.MaxExceeded	Generic.Files.LineLength.MaxExceeded
Warning	github/tests/Events/PullRequestTest.php:1	PHPCS.W.PSR1.Files.SideEffects.FoundWithSymbols	PSR1.Files.SideEffects.FoundWithSymbols
Warning	github/tests/Events/PullRequestTest.php:35	PHPCS.W.Generic.Files.LineLength.TooLong	Generic.Files.LineLength.TooLong
Warning	github/tests/Events/PullRequestTest.php:48	PHPCS.W.Generic.Files.LineLength.TooLong	Generic.Files.LineLength.TooLong

Unit

Tests Passed

Branch

arcpatch-D3598

Build Status

Buildable 5776
Build 6058: arc lint + arc unit

Event Timeline

aceppaluni requested review of this revision.Thu, Nov 21, 18:37

aceppaluni created this revision.

Harbormaster completed remote builds in B5727: Diff 9284.Thu, Nov 21, 18:37

Adapt tests to adhere more to the payload content and our fixes to the Events classes (peer programming session).

Harbormaster completed remote builds in B5776: Diff 9361.Thu, Dec 5, 00:51

Revision Contents
Changeset List

Path

Size

1 line

github/

1 line

tests/

Events/

PullRequestTest.php

65 lines

data/

pull-request-opened.json

520 lines

Diff 9361

composer.json

Loading...

github/composer.json

Loading...

github/tests/Events/PullRequestTest.php

Loading...

github/tests/data/pull-request-opened.json

Loading...