- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed All Stories
All Stories
All Stories
Jan 8 2017
Jan 8 2017
dereckson committed rNOTIF2bd94ba8ce99: Update README to reflect GH->AMQP mirroring removal (authored by dereckson).
Update README to reflect GH->AMQP mirroring removal
Fix docker command in README
dereckson closed D812: Fix docker command in README by committing rNOTIFee4fa18abf48: Fix docker command in README.
Add minimal layout
dereckson closed D813: Add minimal layout by committing rEGLIDEWWWDSGN48c6dbdfc9da: Add minimal layout.
Initial revision
Arcanist configuration
dereckson closed D670: Arcanist configuration by committing rEGLIDEWWWDSGN042fd9097f26: Arcanist configuration.
Update Twitter account. Disable some SCSS components.
Add missing quote
dereckson closed D806: Add missing quote by committing rSTG29732f4aff36: Add missing quote (authored by Thibaut120094).
Prune unused User class
dereckson closed D810: Prune unused User class by committing rNOTIF0492db23a512: Prune unused User class.
dereckson committed rNOTIF27e3ffa5698c: Improve AMQPEventListener code style (authored by dereckson).
Improve AMQPEventListener code style
dereckson committed rNOTIF691289cb6db0: Remove GitHub to AMQP mirror feature (authored by dereckson).
Remove GitHub to AMQP mirror feature
Only remove the feature.
Change touches code style too.
If we don't use it and nobody else does, we can remove the feature instead making it optional.
Jan 7 2017
Jan 7 2017
dereckson committed rNOTIF6653ad57b95c: Improve API replies handling in NotifyNewCommitsToDiffusion (authored by dereckson).
Improve API replies handling in NotifyNewCommitsToDiffusion
dereckson retitled D807: Improve API replies handling in NotifyNewCommitsToDiffusion from Fix NotifyNewCommitsToDiffusion to Improve API replies handling in NotifyNewCommitsToDiffusion.
Simplify test, dataProvider
Quick test for no repo but switch to a provider
dereckson added a comment to T999: NotifyNewCommitsToDiffusion fails to check if we've or not a Phabricator instance for this project.
In T1089#13198, @dereckson wrote:I can repro the regression with the following test:
tests/Jobs/NotifyNewCommitsToDiffusionTest.phppublic function testJobWhenThereIsNoPhabricatorInstanceForTheProject () { $this->mockJob("not-existing-project"); $this->job->handle(); } protected function mockJob(string $project = "acme") { $this->job = new NotifyNewCommitsToDiffusion( $project, "ssh://acme/k2.git" ); }This produces the following stack trace:
Nasqueron\Notifications\Tests\Jobs\NotifyNewCommitsToDiffusionTest::testJobWhenThereIsNoPhabricatorInstanceForTheProject RuntimeException: No credentials for Phabricator project not-existing-project. /app/notifications/app/Phabricator/PhabricatorAPI.php:67 /app/notifications/app/Phabricator/PhabricatorAPIFactory.php:26 /app/notifications/vendor/laravel/framework/src/Illuminate/Support/Facades/Facade.php:217 /app/notifications/app/Jobs/NotifyNewCommitsToDiffusion.php:146 /app/notifications/app/Jobs/NotifyNewCommitsToDiffusion.php:136 /app/notifications/app/Jobs/NotifyNewCommitsToDiffusion.php:75 /app/notifications/tests/Jobs/NotifyNewCommitsToDiffusionTest.php:37
dereckson raised the priority of T999: NotifyNewCommitsToDiffusion fails to check if we've or not a Phabricator instance for this project from Low to High.
dereckson added a comment to T1089: NotifyNewCommitsToDiffusion: RuntimeException: No credentials for Phabricator project ....
I can repro the regression with the following test:
Declare explicitely types
dereckson closed D804: Declare explicitely types by committing rNOTIF5be0d09ea7e0: Declare explicitely types.
Bump keruald/github to 0.2.1 to get rKGHc0e14492852e.
dereckson committed rKGHc0e14492852e: Fix type issue in XHubSignature::parseSignature (authored by dereckson).
Fix type issue in XHubSignature::parseSignature
Jan 6 2017
Jan 6 2017
dereckson added a parent task for T979: Gate for notifications in notifications format: T1080: Zboing web notifications client prototype.
GitHub <noreply@github.com> committed rWPCLIPOLYff2ac7cf8529: Update composer.json (authored by Mati Kärner <mati.karner@gmail.com>).
Update composer.json
GitHub <noreply@github.com> committed rWPCLIPOLY655cc061d6f0: Merge ff2ac7cf85294d16dd8f6062c6c447023cf7179f into… (authored by Mati Kärner <mati.karner@gmail.com>).
Merge ff2ac7cf85294d16dd8f6062c6c447023cf7179f into…
GitHub <noreply@github.com> committed rWPCLIPOLY93172d9cc1c7: Update PolylangHelperFunctions.php (authored by Mati Kärner <mati.karner@gmail.com>).
Update PolylangHelperFunctions.php
GitHub <noreply@github.com> committed rWPCLIPOLYc940afeb7bd9: Update Polylang_Command.php (authored by Mati Kärner <mati.karner@gmail.com>).
Update Polylang_Command.php
GitHub <noreply@github.com> committed rWPCLIPOLYf674a2c094b1: Merge c940afeb7bd977d72a76d284852514febaf81396 into… (authored by Mati Kärner <mati.karner@gmail.com>).
Merge c940afeb7bd977d72a76d284852514febaf81396 into…
dereckson moved T280: Prepare suitable a development server environment for Tasacora from Working on to Next on the Tasacora board.
dereckson moved T267: How are we building our webstack? from Working on to Next on the Tasacora board.
dereckson moved T265: Abstract nina elements to evolve naturally the experimental code into a generic application from Working on to Next on the Tasacora board.
dereckson moved T603: Establish a roadmap to reach a minimum viable product
from Working on to Next on the Tasacora board.
dereckson moved T257: Setup tasacora starting resources from Working on to Pending review on the Tasacora board.
dereckson moved T889: Provide a way to handle code of conduct violation from Backlog to How on the Launch community board.
dereckson reopened T889: Provide a way to handle code of conduct violation, a subtask of T888: [Community] Code of conduct, as Open.
dereckson closed T889: Provide a way to handle code of conduct violation, a subtask of T888: [Community] Code of conduct, as Resolved.
http://laravel-recipes.com/recipes/60/optimizing-the-framework-for-better-performance notes a need to use use statements instead of absolute \namespace\class notation.
Nasqueron DevCentral · If it had been much bigger the moon would have had a core of ice. · Powered by Phabricator